Merge pull request #1218 from github/aeisenberg/move-pack-download-to…

…-init Move calls to pack download to the init action
github · Aug 30, 2022 · d92a91c · d92a91c
2 parents a59fbe2 + 7294b40
commit d92a91c
Show file tree

Hide file tree

Showing 10 changed files with 220 additions and 30 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,7 +2,7 @@
 
 ## [UNRELEASED]
 
-No user facing changes.
+- Downloading CodeQL packs has been moved to the `init` step. Previously, CodeQL packs were downloaded during the `analyze` step. [#1218](https://github.com/github/codeql-action/pull/1218)
 
 ## 2.1.21 - 25 Aug 2022
 

diff --git a/lib/analyze.js b/lib/analyze.js
diff --git a/lib/analyze.js.map b/lib/analyze.js.map
diff --git a/lib/config-utils.js b/lib/config-utils.js
diff --git a/lib/config-utils.js.map b/lib/config-utils.js.map
diff --git a/lib/config-utils.test.js b/lib/config-utils.test.js
diff --git a/lib/config-utils.test.js.map b/lib/config-utils.test.js.map
diff --git a/src/analyze.ts b/src/analyze.ts
@@ -280,21 +280,6 @@ export async function runQueries(
         logger.endGroup();
         logger.info(analysisSummary);
       } else {
-        if (hasPackWithCustomQueries) {
-          logger.info("Performing analysis with custom CodeQL Packs.");
-          logger.startGroup(`Downloading custom packs for ${language}`);
-
-          const results = await codeql.packDownload(packsWithVersion);
-
-          logger.info(
-            `Downloaded packs: ${results.packs
-              .map((r) => `${r.name}@${r.version || "latest"}`)
-              .join(", ")}`
-          );
-
-          logger.endGroup();
-        }
-
         logger.startGroup(`Running queries for ${language}`);
         const querySuitePaths: string[] = [];
         if (queries["builtin"].length > 0) {