Skip to content

Commit

Permalink
Change category uniqueness test
Browse files Browse the repository at this point in the history
Turboscan only allows a single combination of tool name and automation
details id for testing category uniqueness.

Previously, the check in the action was not entirely correct since it
only looked at the _category_ and not the combination of the category
and the tool name.

It's even more precise now since it is looking at the actual, computed
value of the automation details id, rather than an inputted value of
the category.

This change also includes a refactoring where the action is now avoiding
multiple parsing/stringifying of the sarif files. Instead, sarif is
parsed once at the start of the process and stringified once, after
sarif processing is completely finished.
  • Loading branch information
aeisenberg committed Jan 12, 2022
1 parent cbabe47 commit 8454e21
Show file tree
Hide file tree
Showing 18 changed files with 416 additions and 162 deletions.
5 changes: 2 additions & 3 deletions lib/fingerprints.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/fingerprints.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 8 additions & 14 deletions lib/fingerprints.test.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 8454e21

Please sign in to comment.