Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GHSA-4pcg-wr6c-h9cq] fastify/websocket vulnerable to uncaught exception via crash on malformed packet #1849

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

tdunlap607
Copy link
Contributor

Updates

  • Affected products
  • References

Comments
Adding the PR: fastify/fastify-websocket#228

Adding patch link for v5.0.1: fastify/fastify-websocket@7e8c41a

Adding patch link for v7.1.1: fastify/fastify-websocket@c24adeb

These were mentioned in the release of v5.0.1 (https://github.com/fastify/fastify-websocket/releases/tag/v5.0.1) and v7.1.1 (https://github.com/fastify/fastify-websocket/releases/tag/v7.1.1)

@github
Copy link
Collaborator

github commented Mar 29, 2023

Hi there @mcollina! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository.

This change will be reviewed by our highly-trained Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory

@tdunlap607
Copy link
Contributor Author

I'm not sure why the affected products are showing as changed? I only wanted to add the three additional links:

Adding the PR: fastify/fastify-websocket#228

Adding patch link for v5.0.1: fastify/fastify-websocket@7e8c41a

Adding patch link for v7.1.1: fastify/fastify-websocket@c24adeb

Copy link

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version number should not be modified. Also the package is @fastify/websocket and not fastify-websocket (this last one is deprecated).

@advisory-database advisory-database bot merged commit 8b711e4 into main Mar 29, 2023
1 check failed
@advisory-database advisory-database bot deleted the tdunlap607-GHSA-4pcg-wr6c-h9cq branch March 29, 2023 15:52
@advisory-database
Copy link
Contributor

Hi @tdunlap607! Thank you so much for contributing to the GitHub Advisory Database. This database is free, open, and accessible to all, and it's people like you who make it great. Thanks for choosing to help others. We hope you send in more contributions in the future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants