[#4766] Win32: Added support NUMA configuration with multiple count CPU sockets #4896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GermanAizek
force-pushed
the
fix-numa-cores
branch
from
3df26f8
to
1951eb8
Compare
dscho
requested changes
Apr 9, 2024
Comment on lines
+23
to
+26
| typedef BOOL (*WINAPI glpie_t)( | ||
| LOGICAL_PROCESSOR_RELATIONSHIP, | ||
| PSYSTEM_LOGICAL_PROCESSOR_INFORMATION_EX, | ||
| PDWORD); |
There was a problem hiding this comment.
Please move this code to compat/win32/ and use lazyload.h (imitate existing code that declares and initializes the function pointer).
| @@ -18,6 +18,67 @@ | |||
| # endif | |||
| #endif | |||
|
|
|||
| #ifdef GIT_WINDOWS_NATIVE | |||
| /// defines the GetLogicalProcessorInformationEx function | |||
There was a problem hiding this comment.
Please avoid C++-style comments. The existing code does not use them.
| PDWORD); | ||
|
|
||
| // Classic way to get number of cores in windows. | ||
| static size_t get_windows_compatible_n_cores() { |
There was a problem hiding this comment.
Let's not add an extra function here. Instead, let's declare a single win32_online_cpus(void) function in a header file in compat/win32/ and implement it in a .c file. Or put them into compat/mingw.h/compat/mingw.c.
| return 0; | ||
| } | ||
|
|
||
| GetLogicalProcessorInformationEx(RelationAll, NULL, &length); |
There was a problem hiding this comment.
Let's not forget to check the return value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed this issue: #4766