[bugfix] fix wsl mode bits error in subdir #4660
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please ignore the 2 ci errors, it seems they are not related with the modified code |
dscho
reviewed
Oct 30, 2023
| memcpy(buf + off, fse->dirent.d_name, fse->len); | ||
| buf[off + fse->len] = '\0'; | ||
| if (xutftowcs_long_path(wpath, buf) >= 0) | ||
| copy_wsl_mode_bits_from_disk(wpath, -1, &fse->st_mode); |
There was a problem hiding this comment.
fix wsl mode bits bug in subdir
Support for wsl mode bits was previously added to git,
but there was a bug because the filenames provided by
fscache did not contain paths.This commit fixes the issue.
I am sorry, but this commit message does nothing at all to help me to understand while the previous fdata->FileName would not be enough.
Please review https://github.blog/2022-06-30-write-better-commits-build-better-projects/ and improve the commit message accordingly.
There was a problem hiding this comment.
sorry, now commit updated.
Ex: fdata->FileName is only foo.sh while we need path/to/foo.sh to open the file.
Support for wsl mode bits was previously added to git, but there was a bug because the filenames provided by fdata did not contain paths. Ex: fdata->FileName is only foo.sh while we need path/to/foo.sh to open the file. This commit fixes the issue. Signed-off-by: lixungeng <xungeng@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for wsl mode bits was previously added to git, but there was a bug because the filenames provided by fscache did not contain paths.
This commit fixes the issue.
The previous feature is added in PR #4438,
but at that time I didn't tested so much.
Sorry to have this bug.
To test this feature, set core.wslcompat to ture and core.filemode to true and make sure repo is on NTFS.