Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create apt-get release pipeline #221

Merged
merged 26 commits into from
Nov 18, 2020
Merged

Create apt-get release pipeline #221

merged 26 commits into from
Nov 18, 2020

Conversation

kyle-rader
Copy link
Contributor

@kyle-rader kyle-rader commented Nov 17, 2020

Creating a new workflow to be triggered off full release to download the signed .deb asset and deploy it.

The workflow does not currently check if the .deb is actually signed, this is something the repo api will do in the future similar to how it currently does for rpm packages.

Builds now failing because of https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/ set-env usage in the GitVersioning tools :(

@kyle-rader kyle-rader self-assigned this Nov 17, 2020
@kyle-rader kyle-rader added the engineering Refactoring or build changes label Nov 17, 2020
@kyle-rader kyle-rader marked this pull request as ready for review November 17, 2020 12:09
@mjcheetham
Copy link
Collaborator

I've created a PR into the main branch that updates our Nerdbank.GitVersioning to one that uses environment files in GitHub Actions: #224

Once this is merged, we can unblock this branch (might need a rebase).

Copy link
Collaborator

@mjcheetham mjcheetham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just a comment about using the API without auth can lead to throttling by IP address - not something we need to address immediately.

.github/fetch_release.py Show resolved Hide resolved
@kyle-rader
Copy link
Contributor Author

Rebased.

@kyle-rader kyle-rader merged commit ba1fe71 into master Nov 18, 2020
@kyle-rader kyle-rader deleted the user/kyrader/publish branch November 18, 2020 18:21
imgbot bot pushed a commit to Jeverett3000/Git-Credential-Manager-Core that referenced this pull request Nov 2, 2022
Create a new Github workflow for deploying the .deb installer from a release to packages.microsoft.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering Refactoring or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants