Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GPS : gestion des groupes #4050

Merged
merged 8 commits into from May 15, 2024
Merged

GPS : gestion des groupes #4050

merged 8 commits into from May 15, 2024

Conversation

vjousse
Copy link
Contributor

@vjousse vjousse commented May 8, 2024 •
edited

🤔 Pourquoi ?

On veut pouvoir quitter un groupe et choisir d'en être référent ou pas.

🍰 Comment ?

En ajoutant des actions permettant de ne plus suivre un bénéficiaire et d'en être référent ou pas.

  • Utiliser is_active au lieu de supprimer le membre du groupe
  • Vérifier la recherche avec french_unaccent, lorsque l'on cherche henry ça ne fonctionne pas quand on tape henry entier, certainement du au stemming fr

💻 Captures d'écran

Screenshot 2024-05-08 at 14-07-11 - Les emplois de l'inclusion

Screenshot 2024-05-08 at 14-07-19 - Les emplois de l'inclusion

🏝️ Comment tester

@vjousse vjousse added 1-recette-jetable [Payé à l’heure] Crée une recette jetable sur CC no-changelog Ne doit pas figurer dans le journal des changements. labels May 8, 2024
@vjousse vjousse self-assigned this May 8, 2024
@vjousse vjousse force-pushed the gps/manage-group-membership branch from 9b48d46 to 71fddd8 Compare May 8, 2024 12:50
@vjousse vjousse marked this pull request as ready for review May 8, 2024 12:51
@vjousse vjousse added 1-recette-jetable [Payé à l’heure] Crée une recette jetable sur CC and removed 1-recette-jetable [Payé à l’heure] Crée une recette jetable sur CC labels May 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024

🥁 La recette jetable est prête ! 👉 Je veux tester cette PR !

@vjousse vjousse requested a review from celine-m-s May 8, 2024 13:26
@vjousse vjousse force-pushed the gps/manage-group-membership branch from 1f66240 to c26a5b5 Compare May 9, 2024 09:17
@celine-m-s celine-m-s mentioned this pull request May 9, 2024
Closed
2 tasks
celine-m-s
celine-m-s reviewed May 9, 2024
View reviewed changes
itou/static/css/itou.css Outdated Show resolved Hide resolved
celine-m-s
celine-m-s reviewed May 9, 2024
View reviewed changes
itou/users/models.py Outdated Show resolved Hide resolved
celine-m-s
celine-m-s reviewed May 9, 2024
View reviewed changes
itou/www/gps/views.py Outdated Show resolved Hide resolved
celine-m-s
celine-m-s reviewed May 9, 2024
View reviewed changes
itou/www/gps/views.py Outdated Show resolved Hide resolved
celine-m-s
celine-m-s reviewed May 9, 2024
View reviewed changes
itou/www/gps/views.py Outdated Show resolved Hide resolved
celine-m-s
celine-m-s reviewed May 9, 2024
View reviewed changes
Copy link
Collaborator

@celine-m-s celine-m-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai juste une interrogation sur le User.organizations qui pourrait être amélioré. Je te ferai peut-être une proposition alternative un peu plus tard (mais avance sans moi).

@celine-m-s celine-m-s self-requested a review May 9, 2024 12:59
@vjousse vjousse force-pushed the gps/manage-group-membership branch 3 times, most recently from ca212c3 to bc20d68 Compare May 13, 2024 13:53
@celine-m-s celine-m-s self-requested a review May 13, 2024 15:11
@celine-m-s
Copy link
Collaborator

Commits relus ! 👀
J'attends juste que tu testes la modale Bootstrap avec les data attributes et ce sera bon ! :)

@vjousse vjousse force-pushed the gps/manage-group-membership branch from 4b2df45 to 0a7771e Compare May 14, 2024 14:24
celine-m-s
celine-m-s reviewed May 14, 2024
View reviewed changes
tests/gps/tests.py Outdated Show resolved Hide resolved
celine-m-s
celine-m-s approved these changes May 14, 2024
View reviewed changes
Copy link
Collaborator

@celine-m-s celine-m-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super ! 🎉
Ça me paraît prêt pour la prod.

@vjousse vjousse added this pull request to the merge queue May 15, 2024
Merged via the queue into master with commit d29abbb May 15, 2024
11 checks passed
@vjousse vjousse deleted the gps/manage-group-membership branch May 15, 2024 09:08
@celine-m-s celine-m-s mentioned this pull request May 15, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@celine-m-s celine-m-s celine-m-s approved these changes

Assignees

@vjousse vjousse

Labels
1-recette-jetable [Payé à l’heure] Crée une recette jetable sur CC no-changelog Ne doit pas figurer dans le journal des changements.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vjousse @celine-m-s