Générer le changelog automatiquement depuis GitHub [GEN-1526] #3952

francoisfreitag · 2024-04-18T07:49:28Z

🤔 Pourquoi ?

Moins de travail manuel.

🍰 Comment ?

Utilisation de l’outil en ligne de commande gh, qui est disponible par défaut sur les machines des GitHub actions.

Petite tristesse lorsque je me suis aperçu que l’API pull requests ne permet pas de filtrer par date, le script doit donc itérer sur toutes les pull requests. 😢
https://docs.github.com/en/rest/pulls/pulls?apiVersion=2022-11-28#list-pull-requests--parameters

Merci Léo, qui m’a montré l’API gh search :)

Ajout d’une action pour vérifier la cohérence des labels des pull requests.

notion-workspace · 2024-04-18T07:49:38Z

Automatiser le journal des changements

.github/workflows/mkchangelog.yml

scripts/mkchangelog

Makefile

scripts/mkchangelog

francoisfreitag · 2024-04-18T10:18:11Z

Je viens de corriger le tri pour ignorer le markdown.

celine-m-s · 2024-04-19T07:48:05Z

scripts/mkchangelog

+    )
+    pull_requests = json.loads(result.stdout)
+    if len(pull_requests) == limit:
+        sys.exit("Limit has been exceeded when fetching pull requests, keep up the good work!")


1000 PR en une semaine, ça laisse un peu de marge ! 😄

Y'a eu débat sur le nombre de zéro, il faut savoir que François est ambitieux 🥲

celine-m-s

J'aime ! 😍

leo-naeka

Au top 🔥

leo-naeka · 2024-04-19T07:39:30Z

.github/workflows/require-labels.yml

+      - name: Require minimum one label
+        uses: mheap/github-action-required-labels@v5.4.0
+        with:
+          mode: minimum
+          count: 1
+          labels: "ajouté, modifié, supprimé, dependencies, no-changelog"
+
+      - name: Require at most one label
+        uses: mheap/github-action-required-labels@v5.4.0
+        with:
+          mode: maximum
+          count: 1
+          labels: "ajouté, modifié, supprimé, dependencies, no-changelog"


On doit pouvoir simplifier comme ça je pense

Suggested change

- name: Require minimum one label

uses: mheap/github-action-required-labels@v5.4.0

with:

mode: minimum

count: 1

labels: "ajouté, modifié, supprimé, dependencies, no-changelog"

- name: Require at most one label

uses: mheap/github-action-required-labels@v5.4.0

with:

mode: maximum

count: 1

labels: "ajouté, modifié, supprimé, dependencies, no-changelog"

- name: Require exactly one label

uses: mheap/github-action-required-labels@v5.4.0

with:

mode: exactly

count: 1

labels: "ajouté, modifié, supprimé, dependencies, no-changelog"

Bien vu, merci 👍

leo-naeka · 2024-04-19T08:46:44Z

scripts/mkchangelog

+            sprint_end = sprint_start + datetime.timedelta(days=7)
+
+            if missing := list_missing_pull_requests(sprint_start, sprint_end):
+                missing_pull_requests = "\n -".join(pr["url"] for pr in missing)


Suggested change

missing_pull_requests = "\n -".join(pr["url"] for pr in missing)

missing_pull_requests = "\n- ".join(pr["url"] for pr in missing)

L’œil de lynx 😁

francoisfreitag · 2024-04-25T09:13:48Z

Je viens d’ajouter merge_group à la liste des évènements qui déclenche l’action require-label. Sans ça, la PR reste bloquée dans la merge queue en attente du résultat de l’action require-label.
https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-a-merge-queue#triggering-merge-group-checks-with-github-actions

francoisfreitag · 2024-04-25T09:30:05Z

Et évidemment... mheap/github-action-required-labels#66

Use the `gh` tool, it’s available by default on GitHub actions.

francoisfreitag added the no-changelog Ne doit pas figurer dans le journal des changements. label Apr 18, 2024

francoisfreitag self-assigned this Apr 18, 2024

francoisfreitag force-pushed the ff/gha-changelog branch from 0c01344 to 430531d Compare April 18, 2024 07:55

francoisfreitag commented Apr 18, 2024

View reviewed changes

.github/workflows/mkchangelog.yml Outdated Show resolved Hide resolved

francoisfreitag force-pushed the ff/gha-changelog branch from 430531d to 1af1d03 Compare April 18, 2024 08:00

xavfernandez reviewed Apr 18, 2024

View reviewed changes

scripts/mkchangelog Outdated Show resolved Hide resolved

francoisfreitag force-pushed the ff/gha-changelog branch 4 times, most recently from 0b3235d to f00b9e0 Compare April 18, 2024 08:37

xavfernandez reviewed Apr 18, 2024

View reviewed changes

Makefile Outdated Show resolved Hide resolved

scripts/mkchangelog Outdated Show resolved Hide resolved

francoisfreitag force-pushed the ff/gha-changelog branch from f00b9e0 to 7eae803 Compare April 18, 2024 08:46

francoisfreitag marked this pull request as draft April 18, 2024 08:47

francoisfreitag force-pushed the ff/gha-changelog branch 5 times, most recently from 185efa2 to edf5547 Compare April 18, 2024 09:08

This comment was marked as outdated.

Sign in to view

francoisfreitag force-pushed the ff/gha-changelog branch 2 times, most recently from 594ec01 to f5b635f Compare April 18, 2024 10:15

francoisfreitag marked this pull request as ready for review April 18, 2024 10:18

francoisfreitag force-pushed the ff/gha-changelog branch 4 times, most recently from 51bcf1d to 3515d81 Compare April 18, 2024 16:46

francoisfreitag added no-changelog Ne doit pas figurer dans le journal des changements. and removed no-changelog Ne doit pas figurer dans le journal des changements. labels Apr 18, 2024

francoisfreitag force-pushed the ff/gha-changelog branch 2 times, most recently from f43bf19 to 4217863 Compare April 18, 2024 17:05

celine-m-s reviewed Apr 19, 2024

View reviewed changes

celine-m-s approved these changes Apr 19, 2024

View reviewed changes

leo-naeka reviewed Apr 19, 2024

View reviewed changes

francoisfreitag force-pushed the ff/gha-changelog branch from 4217863 to 694743d Compare April 25, 2024 08:39

francoisfreitag added the modifié label Apr 25, 2024

francoisfreitag enabled auto-merge April 25, 2024 08:44

francoisfreitag disabled auto-merge April 25, 2024 08:45

francoisfreitag removed the modifié label Apr 25, 2024

francoisfreitag added this pull request to the merge queue Apr 25, 2024

francoisfreitag removed this pull request from the merge queue due to a manual request Apr 25, 2024

leo-naeka approved these changes Apr 25, 2024

View reviewed changes

francoisfreitag added this pull request to the merge queue Apr 25, 2024

francoisfreitag removed this pull request from the merge queue due to a manual request Apr 25, 2024

francoisfreitag force-pushed the ff/gha-changelog branch 2 times, most recently from a41af0c to 89ae710 Compare April 25, 2024 09:12

francoisfreitag enabled auto-merge April 25, 2024 09:13

francoisfreitag added this pull request to the merge queue Apr 25, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 25, 2024

Automatically populate the changelog from GitHub PRs

a479e93

Use the `gh` tool, it’s available by default on GitHub actions.

francoisfreitag force-pushed the ff/gha-changelog branch from 89ae710 to a479e93 Compare April 25, 2024 09:31

francoisfreitag enabled auto-merge April 25, 2024 09:31

francoisfreitag added this pull request to the merge queue Apr 25, 2024

Merged via the queue into master with commit a011934 Apr 25, 2024
11 checks passed

francoisfreitag deleted the ff/gha-changelog branch April 25, 2024 09:46

francoisfreitag mentioned this pull request Apr 25, 2024

Ajouter une option pour générer la pull request avec mkchangelog #3973

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Générer le changelog automatiquement depuis GitHub [GEN-1526] #3952

Générer le changelog automatiquement depuis GitHub [GEN-1526] #3952

francoisfreitag commented Apr 18, 2024 •

edited

notion-workspace bot commented Apr 18, 2024

This comment was marked as outdated.

francoisfreitag commented Apr 18, 2024

celine-m-s Apr 19, 2024

leo-naeka Apr 19, 2024

celine-m-s left a comment •

edited

leo-naeka left a comment

leo-naeka Apr 19, 2024

francoisfreitag Apr 25, 2024

leo-naeka Apr 19, 2024

francoisfreitag Apr 25, 2024

francoisfreitag commented Apr 25, 2024

francoisfreitag commented Apr 25, 2024

	missing_pull_requests = "\n -".join(pr["url"] for pr in missing)
	missing_pull_requests = "\n- ".join(pr["url"] for pr in missing)

Générer le changelog automatiquement depuis GitHub [GEN-1526] #3952

Générer le changelog automatiquement depuis GitHub [GEN-1526] #3952

Conversation

francoisfreitag commented Apr 18, 2024 • edited

🤔 Pourquoi ?

🍰 Comment ?

notion-workspace bot commented Apr 18, 2024

This comment was marked as outdated.

francoisfreitag commented Apr 18, 2024

celine-m-s Apr 19, 2024

Choose a reason for hiding this comment

leo-naeka Apr 19, 2024

Choose a reason for hiding this comment

celine-m-s left a comment • edited

Choose a reason for hiding this comment

leo-naeka left a comment

Choose a reason for hiding this comment

leo-naeka Apr 19, 2024

Choose a reason for hiding this comment

francoisfreitag Apr 25, 2024

Choose a reason for hiding this comment

leo-naeka Apr 19, 2024

Choose a reason for hiding this comment

francoisfreitag Apr 25, 2024

Choose a reason for hiding this comment

francoisfreitag commented Apr 25, 2024

francoisfreitag commented Apr 25, 2024

francoisfreitag commented Apr 18, 2024 •

edited

celine-m-s left a comment •

edited