Suppression des tests e2e #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedricr
requested changes
Feb 1, 2023
AlexandreCantin
changed the title
cedricr
requested changes
Feb 2, 2023
cedricr
approved these changes
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bon...
Pour les tests unitaires :on ne gérait pas le cas où les services ne sont pas au statut PUBLIÉ => dans ce cas-là, la notion d'obsolescence n'est pas pertinente...on avait perdu les rel=noffollow sur les liens markdown=> les tests unitaires seront modifiés dans une seconde PR (avec ajout d'un pre-commit hook)
Pour les tests e2e => c'est un peu plus compliqué :
.tssinon les modules ne sont pas trouvés...=> globalement, il va falloir définir quelle importance on souhaite donner à ces tests => aller plus loin ou les laisser tomber !