Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phpunit_7_plus #430

Merged
merged 11 commits into from
Jul 2, 2019
Merged

phpunit_7_plus #430

merged 11 commits into from
Jul 2, 2019

Conversation

thewunder
Copy link
Collaborator

@thewunder thewunder commented Mar 6, 2019 •
edited

Let me know what you think, I wan't able to actually run the mobile tests.

Closes #422

@LukeTowers
Copy link

@giorgiosironi what would you need done in order to merge this? We want to use PHPUnit 7+ with OctoberCMS but since we use your library we need your library to support it first.

@JaZo JaZo mentioned this pull request Jul 2, 2019
Closed
@Stepa4man
Copy link

Hey @giorgiosironi, thanks for your lib!
Could you please update me, are you going to merge this PR?
Thanks in advance.

@sivaschenko
Copy link

Hey @giorgiosironi @thewunder please let me know if I can help with this pull request in any way.

PHPUnit 6 is not supported anymore (https://phpunit.de/supported-versions.html) and it is not compatible with PHP 7.3. So it would be awesome for phpunit-selenium to support PHPUnit 7.

@thewunder thewunder merged commit 3129be3 into giorgiosironi:master Jul 2, 2019
@thewunder thewunder deleted the phpunit_7_plus branch July 2, 2019 20:42
@thewunder
Copy link
Collaborator Author

@giorgiosironi One last thing is needed to finish this release out is to notify packagist of the new release so it can be made available. Would that require @sebastianbergmann as he is the maintainer according to packagist?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHPUnit 7 supports ?
4 participants
@thewunder @LukeTowers @Stepa4man @sivaschenko