Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring tests #417

Closed
wants to merge 1 commit into from
Closed

Refactoring tests #417

wants to merge 1 commit into from

Conversation

carusogabriel
Copy link

I've refactored some tests, using:

  • assertCount instead of count function;
  • assertArrayHasKey instead of isset function;
  • assertInternalType instead of is_string function;
  • assertGreaterThan for mathematical comparisons.

@giorgiosironi
Copy link
Owner

The master builds seemed to work at https://travis-ci.org/giorgiosironi/phpunit-selenium/branches while this build is failing for unrelated reasons?

@giorgiosironi
Copy link
Owner

Now master fails too, ok.

@giorgiosironi
Copy link
Owner

Opened sebastianbergmann/phpunit#2950 to check why the master test suite started to fail.

@carusogabriel
Copy link
Author

Ok. I’m out of my home now, but as soon as I return to it, I’ll check the fails!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants