Improved Error Handling in mode.go and fs.go #3756
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… error instead of panic , allowing the caller to decide how to handle it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request includes improvements to error handling in
mode.goandfs.go:SetMode function in
mode.go: Previously, the SetMode function would panic when an unknown mode was provided. This behavior has been modified to return an error instead of causing a panic, allowing for more graceful error handling. The corresponding tests have also been updated to reflect this change.Open function in
fs.go: The error message returned when opening a file has been enhanced to provide better context, similar to the error handling in Python.These changes aim to improve the robustness of the code and provide clearer, more informative error messages to users.