Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support min go version 1.18 #3511

Merged
merged 6 commits into from Mar 1, 2023
Merged

Conversation

thinkerou
Copy link
Member

@thinkerou thinkerou commented Feb 22, 2023

and fixes #2665

@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Merging #3511 (7f7ab66) into master (943e93c) will not change coverage.
The diff coverage is 80.00%.

@@           Coverage Diff           @@
##           master    #3511   +/-   ##
=======================================
  Coverage   98.63%   98.63%           
=======================================
  Files          42       42           
  Lines        3151     3151           
=======================================
  Hits         3108     3108           
  Misses         29       29           
  Partials       14       14           
Flag Coverage Δ
98.63% <80.00%> (ø)
go-1.16 ?
go-1.17 ?
go-1.18 98.54% <80.00%> (ø)
go-1.19 98.63% <80.00%> (ø)
go-1.20 98.63% <80.00%> (ø)
macos-latest 98.63% <80.00%> (ø)
ubuntu-latest 98.63% <80.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
binding/binding.go 100.00% <ø> (ø)
binding/json.go 100.00% <ø> (ø)
binding/msgpack.go 100.00% <ø> (ø)
debug.go 91.66% <0.00%> (ø)
render/msgpack.go 100.00% <ø> (ø)
utils.go 97.00% <ø> (ø)
context.go 97.97% <100.00%> (ø)
deprecated.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@thinkerou thinkerou added this to the v1.10 milestone Feb 23, 2023
@thinkerou thinkerou changed the title chore: min go version 1.18 chore: support min go version 1.18 Feb 23, 2023
context_1.18_test.go Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@mstmdev
Copy link
Contributor

mstmdev commented Feb 25, 2023

Could we delete all the any.go files?

@thinkerou
Copy link
Member Author

Could we delete all the any.go files?

yes, done. please review, thanks!

@mstmdev
Copy link
Contributor

mstmdev commented Feb 27, 2023

image

Replace all the interface{} with any.

@thinkerou
Copy link
Member Author

image

Replace all the interface{} with any.

@mstmdev thanks a lot! done.

@thinkerou
Copy link
Member Author

@appleboy please review, thanks!

@thinkerou thinkerou merged commit 1e1f0b1 into gin-gonic:master Mar 1, 2023
huiyifyj added a commit to Pengxn/go-xn that referenced this pull request Mar 12, 2023
- Update and remove old build tag format.
- Drop support for go versions before 1.18.

Related links:
urfave/cli#1667
gin-gonic/gin#3511
@thinkerou thinkerou modified the milestones: v1.10, v1.9.1 Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

todo: convert to go:build directives
3 participants