Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temp fix install v1.7.5 errror #2951

Closed
wants to merge 1 commit into from
Closed

temp fix install v1.7.5 errror #2951

wants to merge 1 commit into from

Conversation

thinkerou
Copy link
Member

please see #2948 thanks!

@codecov
Copy link

codecov bot commented Nov 22, 2021

Codecov Report

Merging #2951 (8e8288e) into master (57ede9c) will decrease coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2951      +/-   ##
==========================================
- Coverage   98.73%   98.57%   -0.17%     
==========================================
  Files          41       41              
  Lines        3080     3080              
==========================================
- Hits         3041     3036       -5     
- Misses         27       31       +4     
- Partials       12       13       +1     
Flag Coverage Δ
go-1.13 ∅ <ø> (∅)
go-1.14 ∅ <ø> (∅)
go-1.15 ∅ <ø> (∅)
go-1.16 98.57% <ø> (ø)
go-1.17 98.47% <ø> (ø)
macos-latest 98.57% <ø> (-0.17%) ⬇️
nomsgpack 98.55% <ø> (-0.17%) ⬇️
ubuntu-latest 98.57% <ø> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
debug.go 91.66% <0.00%> (-8.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57ede9c...8e8288e. Read the comment docs.

@thinkerou thinkerou changed the title fix install v1.7.5 errror temp fix install v1.7.5 errror Nov 22, 2021
@Bisstocuz
Copy link
Contributor

Bisstocuz commented Nov 22, 2021

@thinkerou Hi, there! I handled one v1.7.5 copy by myself, you can refer to it:
https://github.com/Bisstocuz/gin/commits/v1.7.6

I tested it by go get -u github.com/Bisstocuz/gin@v1.7.6 so I think it should work normally.

And at the same time, you can mark it as v1.7.6 to skip this retracting version.

If need, I can help to open a new pull request copied from #2943 to skip the merge permission limit. (#2952)

@burik666
Copy link

burik666 commented Nov 23, 2021

You SHOULD retract v1.7.5 in go.mod file and release new version (v1.7.6-pre).

if GOPROXY is used, the broken version will be downloads from cache until you retract it.

docker run golang:1.17

$ go env
...
GOPROXY="https://proxy.golang.org,direct"
GOSUMDB="sum.golang.org"
...
$ go get github.com/gin-gonic/gin
go: downloading github.com/gin-gonic/gin v1.7.5
.....
# github.com/gin-gonic/gin
pkg/mod/github.com/gin-gonic/gin@v1.7.5/context.go:735:13: c.engine.AppEngine undefined (type *Engine has no field or method AppEngine)
pkg/mod/github.com/gin-gonic/gin@v1.7.5/gin.go:154:3: unknown field 'UseRawPath' in struct literal of type Engine
pkg/mod/github.com/gin-gonic/gin@v1.7.5/gin.go:156:3: unknown field 'UnescapePathValues' in struct literal of type Engine
pkg/mod/github.com/gin-gonic/gin@v1.7.5/gin.go:508:11: engine.UseRawPath undefined (type *Engine has no field or method UseRawPath)
pkg/mod/github.com/gin-gonic/gin@v1.7.5/gin.go:510:20: engine.UnescapePathValues undefined (type *Engine has no field or method UnescapePathValues)

$ GOPROXY="direct" go get github.com/gin-gonic/gin
go: downloading github.com/gin-gonic/gin v1.7.4
....

https://go.dev/ref/mod#go-mod-file-retract

Go version < 1.16 ignore retract directives.

https://proxy.golang.org/

I removed a bad release from my repository but it still appears in the mirror, what should I do?
Whenever possible, the mirror aims to cache content in order to avoid breaking builds for people that depend on your package, so this bad release may still be available in the mirror even if it is not available at the origin. The same situation applies if you delete your entire repository. We suggest creating a new version and encouraging people to use that one instead.

@thinkerou
Copy link
Member Author

Released v1.7.6 using the code of v1.7.4 version to fix the error at first, please see https://github.com/gin-gonic/gin/releases/tag/v1.7.6, thanks!

@thinkerou
Copy link
Member Author

v1.7.7 have released, thanks! https://github.com/gin-gonic/gin/releases

@thinkerou thinkerou closed this Nov 24, 2021
@thinkerou thinkerou deleted the thinkerou-patch-2 branch November 24, 2021 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants