Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

breaking change to v1.6.0 is inappropriate #2299

Closed
chyroc opened this issue Mar 25, 2020 · 5 comments · Fixed by #2306
Closed

breaking change to v1.6.0 is inappropriate #2299

chyroc opened this issue Mar 25, 2020 · 5 comments · Fixed by #2306
Assignees
@appleboy @thinkerou
Labels
break-backward
Milestone
1.6.2

Comments

@chyroc
Copy link

chyroc commented Mar 25, 2020

#1615 is a breaking change

and it is released to v1.6.0

but for go version style, it is should be released to v2.0.0 and change go.mod to github.com/gin-gonic/gin/v2 (and the package name is gin )

please revert #1615 and put the SameSite param to v2.0.0

thanks.
@vincegio
Copy link

Yep, I agree.
Just updated and had the same issue.. Breaks the value of semver.

@appleboy
Copy link
Member

@thinkerou What do you think? Maybe revert the PR and add the new method to update SameSite value in a cookie?

@thinkerou
Copy link
Member

@thinkerou What do you think? Maybe revert the PR and add the new method to update SameSite value in a cookie?

Yes, add new method, and sign old method deprecated?

@appleboy appleboy added this to the 1.6.2 milestone Mar 27, 2020
@appleboy appleboy mentioned this issue Mar 27, 2020
Merged
@appleboy
Copy link
Member

See the PR: #2306

@appleboy appleboy mentioned this issue Mar 27, 2020
Closed
@appleboy
Copy link
Member

bump to v1.6.2 https://github.com/gin-gonic/gin/releases/tag/v1.6.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@appleboy appleboy

@thinkerou thinkerou

Labels
break-backward
Projects
None yet
Milestone
1.6.2
Development

Successfully merging a pull request may close this issue.

Add set samesite in cookie. gin-gonic/gin
4 participants
@appleboy @thinkerou @vincegio @chyroc