Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with sameSite #232

Closed
Arthur380 opened this issue Jan 31, 2020 · 3 comments · Fixed by #239
Closed

Error with sameSite #232

Arthur380 opened this issue Jan 31, 2020 · 3 comments · Fixed by #239

Comments

@Arthur380
Copy link

Hi,

I have the following errors when i compile my go app.

../github.com/gin-gonic/gin/context.go:778:91: error: reference to undefined identifier ‘http.SameSite’
 func (c *Context) SetCookie(name, value string, maxAge int, path, domain string, sameSite http.SameSite, secure, httpOnly bool) {
                                                                                           ^
../github.com/gin-gonic/gin/context.go:788:3: error: unknown field ‘SameSite’ in ‘http.Cookie’
   SameSite: sameSite,
   ^

I know that this issue can be solved if we add http.SameSiteLaxMode, but I use docker environment and then I would prefer to not modify the gin-jwt sources.

If you can help me, thanks.

@kjozic
Copy link

kjozic commented Mar 25, 2020

This is related to issue #230.

@appleboy
Copy link
Owner

I will take it.

@appleboy
Copy link
Owner

See gin-gonic/gin#2299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants