Skip to content

Commit

Permalink
Update gin_integration_test.go (#2341)
Browse files Browse the repository at this point in the history
* Update gin_integration_test.go

TestUnixSocket fails if you run it twice in a row.  This is due to the unix socket file persisting.  Added defer to clean up.

Whats unclear is the following test TestBadUnixSocket I suspect is just looking for cruft maybe from a prior test or defaults not working, I have not enough background to say.

* Update gin_integration_test.go

I believe there is some tab issue here, tried to manual overwrite it now.

* Update gin_integration_test.go

squash you dang spaces!!!
  • Loading branch information
ronaldpetty committed Apr 28, 2020
1 parent be4ba7d commit 4427ca4
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions gin_integration_test.go
Expand Up @@ -146,15 +146,19 @@ func TestRunWithPort(t *testing.T) {
func TestUnixSocket(t *testing.T) {
router := New()

unixTestSocket := "/tmp/unix_unit_test"

defer os.Remove(unixTestSocket)

go func() {
router.GET("/example", func(c *Context) { c.String(http.StatusOK, "it worked") })
assert.NoError(t, router.RunUnix("/tmp/unix_unit_test"))
assert.NoError(t, router.RunUnix(unixTestSocket))
}()
// have to wait for the goroutine to start and run the server
// otherwise the main thread will complete
time.Sleep(5 * time.Millisecond)

c, err := net.Dial("unix", "/tmp/unix_unit_test")
c, err := net.Dial("unix", unixTestSocket)
assert.NoError(t, err)

fmt.Fprint(c, "GET /example HTTP/1.0\r\n\r\n")
Expand Down

0 comments on commit 4427ca4

Please sign in to comment.