write/macho: ensure Mach-O subsections are not zero size #676
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Mach-O,
add_symbol_data
now ensures that the symbol size is at least 1 when subsections via symbols are enabled. This change was made to support linking with ld-prime. It is also unclear how this previously managed to work with ld64.write::Object::add_subsection
no longer enables subsections via symbols for Mach-O. Useset_subsections_via_symbols
instead. This change was made because Mach-O subsections are all or nothing, so this decision must be made before any symbols are added.write::Object::add_subsection
no longer adds data to the subsection. This change was made because it was done withappend_section_data
, but this is often not the correct way to add data to the subsection. Usuallyadd_symbol_data
is a better choice.