elf: Update LoongArch eflags #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a revision of LoongArch ELF ABI [1], it was decided that ILP32
objects must use ELFCLASS32. Now both LP64D and ILP32D will use the
same number (0x1) for "double float", so EF_LARCH_ABI_LP64{S,F,D} are
renamed and EF_LARCH_ABI_ILP32{S,F,D} are removed.
The change is ABI-compatible for LP64, but not API-compatible. ILP32 is
not supported by GCC and Glibc yet so it's not really used anyway.
And, a seperate bit is allocated to indicate if the ELF object file uses
any relocation type directly writing to immediate slots [2].
Update the code to match these changes.
[1]:https://github.com/loongson/LoongArch-Documentation/pull/47/files#diff-711b3e7b6a005b492898ac6d93f2d8d37c00e0831e210993a6f9dbb26c043717
[2]:https://github.com/loongson/LoongArch-Documentation/pull/61/files#diff-711b3e7b6a005b492898ac6d93f2d8d37c00e0831e210993a6f9dbb26c043717
philipc
approved these changes
Nov 9, 2022
|
Note that this is a breaking change. Do you think that there will continue to be breaking changes for the LoongArch definitions? While it's okay to have a breaking change now (there's other breaking changes already), it would be nice to avoid if possible. |
I don't think this will happen again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a revision of LoongArch ELF ABI [1], it was decided that ILP32 objects must use ELFCLASS32. Now both LP64D and ILP32D will use the same number (0x1) for "double float", so EF_LARCH_ABI_LP64{S,F,D} are renamed and EF_LARCH_ABI_ILP32{S,F,D} are removed.
The change is ABI-compatible for LP64, but not API-compatible. ILP32 is not supported by GCC and Glibc yet so it's not really used anyway.
And, a seperate bit is allocated to indicate if the ELF object file uses any relocation type directly writing to immediate slots [2].
Update the code to match these changes.
[1]:https://github.com/loongson/LoongArch-Documentation/pull/47/files#diff-711b3e7b6a005b492898ac6d93f2d8d37c00e0831e210993a6f9dbb26c043717 [2]:https://github.com/loongson/LoongArch-Documentation/pull/61/files#diff-711b3e7b6a005b492898ac6d93f2d8d37c00e0831e210993a6f9dbb26c043717