Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add powerpc handling macho. #460

Merged
merged 4 commits into from Sep 1, 2022
Merged

Add powerpc handling macho. #460

merged 4 commits into from Sep 1, 2022

Conversation

uglyoldbob
Copy link
Contributor

Add parsing for the powerpc and powerpc64 architecture types on the macho object type.

Add parsing for the powerpc and powerpc64 architecture types on the macho object type.
@bjorn3
Copy link
Contributor

bjorn3 commented Aug 27, 2022

I think

fn architecture(&self) -> Architecture {
also needs them.

@philipc
Copy link
Contributor

philipc commented Aug 30, 2022

Can you please support these for writing too:

object/src/write/macho.rs

Lines 324 to 328 in 1685737

let (cputype, cpusubtype) = match self.architecture {
Architecture::Arm => (macho::CPU_TYPE_ARM, macho::CPU_SUBTYPE_ARM_ALL),
Architecture::Aarch64 => (macho::CPU_TYPE_ARM64, macho::CPU_SUBTYPE_ARM64_ALL),
Architecture::I386 => (macho::CPU_TYPE_X86, macho::CPU_SUBTYPE_I386_ALL),
Architecture::X86_64 => (macho::CPU_TYPE_X86_64, macho::CPU_SUBTYPE_X86_64_ALL),

Copy link
Contributor

@philipc philipc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@philipc philipc merged commit 24a98f1 into gimli-rs:master Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants