Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Search all ImageDebugDirectory entries for CodeView records #451

Merged
merged 1 commit into from Aug 1, 2022

Conversation

Swatinem
Copy link
Contributor

There can be more than one ImageDebugDirectory entries, and any of those
can be the CodeView record we are looking for.

There can be more than one ImageDebugDirectory entries, and any of those
can be the CodeView record we are looking for.
@Swatinem
Copy link
Contributor Author

fun fact: I wrote a detailed blog post about how I made this discovery: https://swatinem.de/blog/format-ossification/

Copy link
Contributor

@philipc philipc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Can you give me a pointer on how to obtain one of these files for testing? I would like to update the readobj example to display the ImageDebugDirectory array, and it would be useful for testing that.

@philipc philipc merged commit 40d77b2 into gimli-rs:master Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants