Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stylelint-config-idiomatic-order to package.json and README #51

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

azzcatdesign
Copy link

No description provided.

@gilbarbara
Copy link
Owner

hey @azzcatdesign

You need to install the new dependency with npm and commit the package-lock.json.
Also, can you please add tests?

thanks

@azzcatdesign
Copy link
Author

azzcatdesign commented Mar 3, 2021

Ah, sorry! Was following earlier example and didn't realize.

Looks like I'm in over my head. I can install stylelint-config-idiomatic-order as a dev dependency via npm, but that's not what you're looking for here. I have no idea how to tackle an installation via npm similar to SUIT CSS:

"stylelint-config-suitcss": {
      "version": "15.0.0",
      "resolved": "https://registry.npmjs.org/stylelint-config-suitcss/-/stylelint-config-suitcss-15.0.0.tgz",
      "integrity": "sha512-MVkhy8oPuFt1I2+TKqdKxukstNQ5oQDHtztBVNVL6uS2ZwRGE2hqq+Hc1Q5bXZswH6ApoQfdbjCmS8N3avwsBg==",
      "requires": {
        "stylelint-order": "^4.1.0",
        "stylelint-suitcss": "^3.0.0"
      }
    },

Nor do I know how to add tests.

Apologies.

@gilbarbara
Copy link
Owner

It's not so simple, you'll need to set up the docker environment to run codeclimate locally and analyze a file that uses the new dependency to make sure it is working...

If you enable "Allow edits from maintainers" in this PR, I can add the test later.

@azzcatdesign
Copy link
Author

Edits enabled. Setting up a Docker environment on my own is not in my wheelhouse.

Thanks.

@nitaigao
Copy link

Any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants