Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade stylelint to 13.3.0 #45

Closed
wants to merge 3 commits into from
Closed

Conversation

fede-moya
Copy link
Contributor

There is a known issue on the latest version of stylelint, which blocks some folks from using the latest version. It would be great if we could add a branch that points to the the latest version previous to the addition of the issue. The idea is to create a new branch named 13.3.0 or something that indicates the locked version of stylint holded in that branch, and merge this PR against that branch.

@fede-moya
Copy link
Contributor Author

Hey there @gilbarbara 👋🏼 , hope you are doing fine. I'm Federico, part of Codeclimate's stuff, we have recently updated our engines to use the latest changes of this repository, which lead us to run the latest version of stylelint, suddenly some folks that were using the styelint engine started to complain about the known issue of stylelint referenced in the description of the PR. We would like to have support for both the latest version of stylelint for those folks interesed in using the latest version that do not care about the existent issue, but we would also like to offer a more recent version of stylint that doest not includes the named issue. That's why we opened this PR.

Does this makes sense to you, do you think we can merge this one into a new bran different from master ?

Regards !

@gilbarbara
Copy link
Owner

hey @fede-moya

Stylelint released a new version yesterday (13.8.0) that has the fix for this issue. Can you please check if it's working?

@fede-moya
Copy link
Contributor Author

fede-moya commented Nov 18, 2020

@gilbarbara hey there !

I have just checked the release notes of version 13.8.0 and I haven't seen any change that could be interpreted as a fix for stylelint/stylelint#4793 . Could you point me to that change ?

@gilbarbara
Copy link
Owner

@fede-moya

The issue you've mentioned has a PR that was merged

Anyway, do you work at codeclimate? How it would work with two engines with the same major version? Isn't better to downgrade the whole engine?
I don't use this engine anymore...

@fede-moya
Copy link
Contributor Author

fede-moya commented Nov 18, 2020

First, thanks for helping me with this 👍🏼 .

Yes, I do work for codeclimate. There is a setting that allows you to choose a specific "channel" of an engine, which pretty much stands for version. So, it's possible and also normal to specify different minor versions of an engine, particularly for engines like rubocop.

I would had try to downgrade the whole engine, but that would imply to use version 9 of stylelint wich is the previous version that we were running, which is to old and thereby not acceptable for us. That's why I opened this PR, for offering a different version of stylelint that refers to the latest major release.

I did saw that there was a PR merged as an attempt to fix the known issue, but there were are also two more comments on the issue, claiming that the problem is still remaining. --> stylelint/stylelint#4793 (comment) , considering that and the fact that the issue is still actually opened I figured that it was still a problem. Even if the pr that got merged as a potential fix actually solves part of the problem, seems like it doesn't cover all cases that's why I still think it's worthy to offer a new channel pointing to version 13.3.0.

Regarding the fact that you are not using the engine anymore, if you would like to also quit the maintenance of this engine I could fork it and maintaining under the codeclimate-community organization, that would be no problem.

@fede-moya fede-moya closed this Dec 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants