Remove unused leading_zero_possible field

Mirrors google/libphonenumber#2821
giggsey · Oct 28, 2022 · 5c2965d · 5c2965d
1 parent d886563
commit 5c2965d
Show file tree

Hide file tree

Showing 584 changed files with 8 additions and 620 deletions.
diff --git a/build/MetadataFilter.php b/build/MetadataFilter.php
@@ -49,7 +49,6 @@ class MetadataFilter
         'nationalPrefixTransformRule',
         'sameMobileAndFixedLinePattern',
         'mainCountryForCode',
-        'leadingZeroPossible',
         'mobileNumberPortableRegion'
     );
 
@@ -316,10 +315,6 @@ public function filterMetadata(PhoneMetadata $metadata)
             $metadata->clearMainCountryForCode();
         }
 
-        if ($this->shouldDrop('leadingZeroPossible')) {
-            $metadata->clearLeadingZeroPossible();
-        }
-
         if ($this->shouldDrop('mobileNumberPortableRegion')) {
             $metadata->clearMobileNumberPortableRegion();
         }

diff --git a/phpunit.xml.dist b/phpunit.xml.dist
@@ -1,6 +1,10 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <phpunit bootstrap="./tests/bootstrap.php"
          beStrictAboutTestsThatDoNotTestAnything="false"
+         convertWarningsToExceptions="true"
+         convertNoticesToExceptions="true"
+         convertErrorsToExceptions="true"
+         convertDeprecationsToExceptions="true"
          colors="true">
 
     <testsuites>

diff --git a/src/PhoneMetadata.php b/src/PhoneMetadata.php
@@ -25,7 +25,6 @@ class PhoneMetadata
     protected $nationalPrefix;
     protected $preferredExtnPrefix;
     protected $mainCountryForCode = false;
-    protected $leadingZeroPossible = false;
     protected $mobileNumberPortableRegion = false;
     protected $generalDesc;
     /**
@@ -118,11 +117,6 @@ public function clearMainCountryForCode()
         return $this;
     }
 
-    public function hasLeadingZeroPossible()
-    {
-        return $this->leadingZeroPossible !== null;
-    }
-
     public function hasMobileNumberPortableRegion()
     {
         return $this->mobileNumberPortableRegion !== null;
@@ -288,10 +282,6 @@ public function toArray()
             $output['leadingDigits'] = $this->getLeadingDigits();
         }
 
-        if ($this->hasLeadingZeroPossible()) {
-            $output['leadingZeroPossible'] = $this->isLeadingZeroPossible();
-        }
-
         if ($this->hasMobileNumberPortableRegion()) {
             $output['mobileNumberPortableRegion'] = $this->isMobileNumberPortableRegion();
         }
@@ -807,23 +797,6 @@ public function setLeadingDigits($value)
         return $this;
     }
 
-    public function isLeadingZeroPossible()
-    {
-        return $this->leadingZeroPossible;
-    }
-
-    public function setLeadingZeroPossible($value)
-    {
-        $this->leadingZeroPossible = $value;
-        return $this;
-    }
-
-    public function clearLeadingZeroPossible()
-    {
-        $this->leadingZeroPossible = false;
-        return $this;
-    }
-
     public function isMobileNumberPortableRegion()
     {
         return $this->mobileNumberPortableRegion;
@@ -976,10 +949,6 @@ public function fromArray(array $input)
             $this->setLeadingDigits($input['leadingDigits']);
         }
 
-        if (isset($input['leadingZeroPossible'])) {
-            $this->setLeadingZeroPossible($input['leadingZeroPossible']);
-        }
-
         if (isset($input['mobileNumberPortableRegion'])) {
             $this->setMobileNumberPortableRegion($input['mobileNumberPortableRegion']);
         }

diff --git a/src/PhoneNumberUtil.php b/src/PhoneNumberUtil.php
@@ -2813,7 +2813,7 @@ public function formatOutOfCountryCallingNumber(PhoneNumber $number, $regionCall
      */
     public function isNANPACountry($regionCode)
     {
-        return in_array(strtoupper($regionCode), $this->nanpaRegions);
+        return in_array(strtoupper((string)$regionCode), $this->nanpaRegions);
     }
 
     /**

diff --git a/src/ShortNumberInfo.php b/src/ShortNumberInfo.php
@@ -130,7 +130,7 @@ public function getExampleShortNumber($regionCode)
      */
     public function getMetadataForRegion($regionCode)
     {
-        $regionCode = strtoupper($regionCode);
+        $regionCode = strtoupper((string)$regionCode);
 
         if (!in_array($regionCode, ShortNumbersRegionCodeSet::$shortNumbersRegionCodeSet)) {
             return null;

diff --git a/src/data/PhoneNumberAlternateFormats_255.php b/src/data/PhoneNumberAlternateFormats_255.php
@@ -47,6 +47,5 @@
   array (
   ),
   'mainCountryForCode' => false,
-  'leadingZeroPossible' => false,
   'mobileNumberPortableRegion' => false,
 );
diff --git a/src/data/PhoneNumberAlternateFormats_27.php b/src/data/PhoneNumberAlternateFormats_27.php
@@ -35,6 +35,5 @@
   array (
   ),
   'mainCountryForCode' => false,
-  'leadingZeroPossible' => false,
   'mobileNumberPortableRegion' => false,
 );
diff --git a/src/data/PhoneNumberAlternateFormats_30.php b/src/data/PhoneNumberAlternateFormats_30.php
@@ -35,6 +35,5 @@
   array (
   ),
   'mainCountryForCode' => false,
-  'leadingZeroPossible' => false,
   'mobileNumberPortableRegion' => false,
 );
diff --git a/src/data/PhoneNumberAlternateFormats_31.php b/src/data/PhoneNumberAlternateFormats_31.php
@@ -47,6 +47,5 @@
   array (
   ),
   'mainCountryForCode' => false,
-  'leadingZeroPossible' => false,
   'mobileNumberPortableRegion' => false,
 );
diff --git a/src/data/PhoneNumberAlternateFormats_34.php b/src/data/PhoneNumberAlternateFormats_34.php
@@ -47,6 +47,5 @@
   array (
   ),
   'mainCountryForCode' => false,
-  'leadingZeroPossible' => false,
   'mobileNumberPortableRegion' => false,
 );
diff --git a/src/data/PhoneNumberAlternateFormats_350.php b/src/data/PhoneNumberAlternateFormats_350.php
@@ -35,6 +35,5 @@
   array (
   ),
   'mainCountryForCode' => false,
-  'leadingZeroPossible' => false,
   'mobileNumberPortableRegion' => false,
 );
diff --git a/src/data/PhoneNumberAlternateFormats_351.php b/src/data/PhoneNumberAlternateFormats_351.php
@@ -59,6 +59,5 @@
   array (
   ),
   'mainCountryForCode' => false,
-  'leadingZeroPossible' => false,
   'mobileNumberPortableRegion' => false,
 );
diff --git a/src/data/PhoneNumberAlternateFormats_352.php b/src/data/PhoneNumberAlternateFormats_352.php
@@ -35,6 +35,5 @@
   array (
   ),
   'mainCountryForCode' => false,
-  'leadingZeroPossible' => false,
   'mobileNumberPortableRegion' => false,
 );
diff --git a/src/data/PhoneNumberAlternateFormats_358.php b/src/data/PhoneNumberAlternateFormats_358.php
@@ -59,6 +59,5 @@
   array (
   ),
   'mainCountryForCode' => false,
-  'leadingZeroPossible' => false,
   'mobileNumberPortableRegion' => false,
 );
diff --git a/src/data/PhoneNumberAlternateFormats_359.php b/src/data/PhoneNumberAlternateFormats_359.php
@@ -59,6 +59,5 @@
   array (
   ),
   'mainCountryForCode' => false,
-  'leadingZeroPossible' => false,
   'mobileNumberPortableRegion' => false,
 );
diff --git a/src/data/PhoneNumberAlternateFormats_36.php b/src/data/PhoneNumberAlternateFormats_36.php
@@ -46,6 +46,5 @@
   array (
   ),
   'mainCountryForCode' => false,
-  'leadingZeroPossible' => false,
   'mobileNumberPortableRegion' => false,
 );
diff --git a/src/data/PhoneNumberAlternateFormats_372.php b/src/data/PhoneNumberAlternateFormats_372.php
@@ -59,6 +59,5 @@
   array (
   ),
   'mainCountryForCode' => false,
-  'leadingZeroPossible' => false,
   'mobileNumberPortableRegion' => false,
 );
diff --git a/src/data/PhoneNumberAlternateFormats_373.php b/src/data/PhoneNumberAlternateFormats_373.php
@@ -47,6 +47,5 @@
   array (
   ),
   'mainCountryForCode' => false,
-  'leadingZeroPossible' => false,
   'mobileNumberPortableRegion' => false,
 );
diff --git a/src/data/PhoneNumberAlternateFormats_380.php b/src/data/PhoneNumberAlternateFormats_380.php
@@ -47,6 +47,5 @@
   array (
   ),
   'mainCountryForCode' => false,
-  'leadingZeroPossible' => false,
   'mobileNumberPortableRegion' => false,
 );
diff --git a/src/data/PhoneNumberAlternateFormats_381.php b/src/data/PhoneNumberAlternateFormats_381.php
@@ -59,6 +59,5 @@
   array (
   ),
   'mainCountryForCode' => false,
-  'leadingZeroPossible' => false,
   'mobileNumberPortableRegion' => false,
 );
diff --git a/src/data/PhoneNumberAlternateFormats_385.php b/src/data/PhoneNumberAlternateFormats_385.php
@@ -71,6 +71,5 @@
   array (
   ),
   'mainCountryForCode' => false,
-  'leadingZeroPossible' => false,
   'mobileNumberPortableRegion' => false,
 );
diff --git a/src/data/PhoneNumberAlternateFormats_39.php b/src/data/PhoneNumberAlternateFormats_39.php
@@ -47,6 +47,5 @@
   array (
   ),
   'mainCountryForCode' => false,
-  'leadingZeroPossible' => false,
   'mobileNumberPortableRegion' => false,
 );
diff --git a/src/data/PhoneNumberAlternateFormats_43.php b/src/data/PhoneNumberAlternateFormats_43.php
@@ -179,6 +179,5 @@
   array (
   ),
   'mainCountryForCode' => false,
-  'leadingZeroPossible' => false,
   'mobileNumberPortableRegion' => false,
 );
diff --git a/src/data/PhoneNumberAlternateFormats_44.php b/src/data/PhoneNumberAlternateFormats_44.php
@@ -83,6 +83,5 @@
   array (
   ),
   'mainCountryForCode' => false,
-  'leadingZeroPossible' => false,
   'mobileNumberPortableRegion' => false,
 );
diff --git a/src/data/PhoneNumberAlternateFormats_49.php b/src/data/PhoneNumberAlternateFormats_49.php
@@ -515,6 +515,5 @@
   array (
   ),
   'mainCountryForCode' => false,
-  'leadingZeroPossible' => false,
   'mobileNumberPortableRegion' => false,
 );
diff --git a/src/data/PhoneNumberAlternateFormats_505.php b/src/data/PhoneNumberAlternateFormats_505.php
@@ -35,6 +35,5 @@
   array (
   ),
   'mainCountryForCode' => false,
-  'leadingZeroPossible' => false,
   'mobileNumberPortableRegion' => false,
 );
diff --git a/src/data/PhoneNumberAlternateFormats_506.php b/src/data/PhoneNumberAlternateFormats_506.php
@@ -34,6 +34,5 @@
   array (
   ),
   'mainCountryForCode' => false,
-  'leadingZeroPossible' => false,
   'mobileNumberPortableRegion' => false,
 );
diff --git a/src/data/PhoneNumberAlternateFormats_52.php b/src/data/PhoneNumberAlternateFormats_52.php
@@ -47,6 +47,5 @@
   array (
   ),
   'mainCountryForCode' => false,
-  'leadingZeroPossible' => false,
   'mobileNumberPortableRegion' => false,
 );
diff --git a/src/data/PhoneNumberAlternateFormats_54.php b/src/data/PhoneNumberAlternateFormats_54.php
@@ -47,6 +47,5 @@
   array (
   ),
   'mainCountryForCode' => false,
-  'leadingZeroPossible' => false,
   'mobileNumberPortableRegion' => false,
 );
diff --git a/src/data/PhoneNumberAlternateFormats_55.php b/src/data/PhoneNumberAlternateFormats_55.php
@@ -35,6 +35,5 @@
   array (
   ),
   'mainCountryForCode' => false,
-  'leadingZeroPossible' => false,
   'mobileNumberPortableRegion' => false,
 );
diff --git a/src/data/PhoneNumberAlternateFormats_58.php b/src/data/PhoneNumberAlternateFormats_58.php
@@ -34,6 +34,5 @@
   array (
   ),
   'mainCountryForCode' => false,
-  'leadingZeroPossible' => false,
   'mobileNumberPortableRegion' => false,
 );
diff --git a/src/data/PhoneNumberAlternateFormats_595.php b/src/data/PhoneNumberAlternateFormats_595.php
@@ -59,6 +59,5 @@
   array (
   ),
   'mainCountryForCode' => false,
-  'leadingZeroPossible' => false,
   'mobileNumberPortableRegion' => false,
 );
diff --git a/src/data/PhoneNumberAlternateFormats_61.php b/src/data/PhoneNumberAlternateFormats_61.php
@@ -68,6 +68,5 @@
   array (
   ),
   'mainCountryForCode' => false,
-  'leadingZeroPossible' => false,
   'mobileNumberPortableRegion' => false,
 );
diff --git a/src/data/PhoneNumberAlternateFormats_62.php b/src/data/PhoneNumberAlternateFormats_62.php
@@ -95,6 +95,5 @@
   array (
   ),
   'mainCountryForCode' => false,
-  'leadingZeroPossible' => false,
   'mobileNumberPortableRegion' => false,
 );
diff --git a/src/data/PhoneNumberAlternateFormats_64.php b/src/data/PhoneNumberAlternateFormats_64.php
@@ -47,6 +47,5 @@
   array (
   ),
   'mainCountryForCode' => false,
-  'leadingZeroPossible' => false,
   'mobileNumberPortableRegion' => false,
 );
diff --git a/src/data/PhoneNumberAlternateFormats_66.php b/src/data/PhoneNumberAlternateFormats_66.php
@@ -35,6 +35,5 @@
   array (
   ),
   'mainCountryForCode' => false,
-  'leadingZeroPossible' => false,
   'mobileNumberPortableRegion' => false,
 );
diff --git a/src/data/PhoneNumberAlternateFormats_675.php b/src/data/PhoneNumberAlternateFormats_675.php
@@ -35,6 +35,5 @@
   array (
   ),
   'mainCountryForCode' => false,
-  'leadingZeroPossible' => false,
   'mobileNumberPortableRegion' => false,
 );
diff --git a/src/data/PhoneNumberAlternateFormats_676.php b/src/data/PhoneNumberAlternateFormats_676.php
@@ -35,6 +35,5 @@
   array (
   ),
   'mainCountryForCode' => false,
-  'leadingZeroPossible' => false,
   'mobileNumberPortableRegion' => false,
 );
diff --git a/src/data/PhoneNumberAlternateFormats_679.php b/src/data/PhoneNumberAlternateFormats_679.php
@@ -35,6 +35,5 @@
   array (
   ),
   'mainCountryForCode' => false,
-  'leadingZeroPossible' => false,
   'mobileNumberPortableRegion' => false,
 );
diff --git a/src/data/PhoneNumberAlternateFormats_7.php b/src/data/PhoneNumberAlternateFormats_7.php
@@ -95,6 +95,5 @@
   array (
   ),
   'mainCountryForCode' => false,
-  'leadingZeroPossible' => false,
   'mobileNumberPortableRegion' => false,
 );
diff --git a/src/data/PhoneNumberAlternateFormats_81.php b/src/data/PhoneNumberAlternateFormats_81.php
@@ -59,6 +59,5 @@
   array (
   ),
   'mainCountryForCode' => false,
-  'leadingZeroPossible' => false,
   'mobileNumberPortableRegion' => false,
 );
diff --git a/src/data/PhoneNumberAlternateFormats_84.php b/src/data/PhoneNumberAlternateFormats_84.php
@@ -59,6 +59,5 @@
   array (
   ),
   'mainCountryForCode' => false,
-  'leadingZeroPossible' => false,
   'mobileNumberPortableRegion' => false,
 );
diff --git a/src/data/PhoneNumberAlternateFormats_855.php b/src/data/PhoneNumberAlternateFormats_855.php
@@ -34,6 +34,5 @@
   array (
   ),
   'mainCountryForCode' => false,
-  'leadingZeroPossible' => false,
   'mobileNumberPortableRegion' => false,
 );
diff --git a/src/data/PhoneNumberAlternateFormats_856.php b/src/data/PhoneNumberAlternateFormats_856.php
@@ -56,6 +56,5 @@
   array (
   ),
   'mainCountryForCode' => false,
-  'leadingZeroPossible' => false,
   'mobileNumberPortableRegion' => false,
 );
diff --git a/src/data/PhoneNumberAlternateFormats_90.php b/src/data/PhoneNumberAlternateFormats_90.php
@@ -47,6 +47,5 @@
   array (
   ),
   'mainCountryForCode' => false,
-  'leadingZeroPossible' => false,
   'mobileNumberPortableRegion' => false,
 );