-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add template for PolicyExceptions #1151
Draft
mcharriere
wants to merge
9
commits into
main
Choose a base branch
from
polex
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcharriere
changed the title
add template for PolicyException
add template for PolicyExceptions
Oct 24, 2023
mcharriere
force-pushed
the
polex
branch
2 times, most recently
from
October 28, 2023 10:44
40eebce
to
d01d643
Compare
I like this idea, will pick this up this week. |
Signed-off-by: Matias Charriere <matias@giantswarm.io>
Signed-off-by: Matias Charriere <matias@giantswarm.io>
Signed-off-by: Matias Charriere <matias@giantswarm.io>
Signed-off-by: Matias Charriere <matias@giantswarm.io>
Signed-off-by: Matias Charriere <matias@giantswarm.io>
Signed-off-by: Matias Charriere <matias@giantswarm.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add policyexception templating command based on PolicyExceptionDraft
What is the effect of this change to users?
User is able to generate a PolicyException based on an existing PolicyExceptionDraft.
What does it look like?
Given the following
PolicyExceptionDraft
the new template command can generate:
Any background context you can provide?
https://github.com/giantswarm/rfc/tree/main/policy-orchestration#policyexception
What is needed from the reviewers?
Do the docs need to be updated?
Should this change be mentioned in the release notes?
Is this a breaking change?
(Breaking changes are, for example, removal of commnds/flags or substantial changes in the meaning of a flag. If yes, please add the
breaking-change
label to the PR.)