Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log with level error when helm release fails #1101

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

marians
Copy link
Member

@marians marians commented Feb 8, 2024

Little improvement to raise the visibility of actual errors in logs

Checklist

  • Update changelog in CHANGELOG.md.

@marians marians self-assigned this Feb 8, 2024
@marians marians marked this pull request as ready for review February 8, 2024 13:32
@marians marians requested a review from a team as a code owner February 8, 2024 13:32
@marians
Copy link
Member Author

marians commented Feb 8, 2024

Seems like I misunderstood the Errorf function. I thought it would mean to emit a message with level error, but it requires the parameter to actually be an error.

cannot use "helm release %#q failed, %s" (constant of type string) as error value in argument to r.logger.Errorf: string does not implement error (missing method Error)

@ljakimczuk
Copy link
Contributor

@marians you can pass to it the err you have access to

@marians
Copy link
Member Author

marians commented Mar 14, 2024

Modified the call to Errorf. PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants