feat: add virtual memory compatibility for zfs arc architectures #2385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hewdoe
force-pushed
the
zfs-arc-compatibility
branch
from
0857e40
to
c513437
Compare
…ce code) Signed-off-by: Hudson Gerwing <grownuphudson@gmail.com> docs: update HISTORY/CREDITS Signed-off-by: Hudson Gerwing <grownuphudson@gmail.com> fix: various fixes on account of me not having my linter on: poor type hinting incorrect column unpacking of the zfs arc stats file bad variable naming Signed-off-by: Hudson Gerwing <grownuphudson@gmail.com> fix: account for shared memory, errant conversion of zfs stats Signed-off-by: Hudson Gerwing <grownuphudson@gmail.com> refactor: move arc stats call to a separate function to be less obtrusive Signed-off-by: Hudson Gerwing <grownuphudson@gmail.com>
hewdoe
force-pushed
the
zfs-arc-compatibility
branch
from
5ba3d04
to
bdba14a
Compare
Signed-off-by: Hudson Gerwing <grownuphudson@gmail.com>
hewdoe
force-pushed
the
zfs-arc-compatibility
branch
from
b43e2a8
to
10d412a
Compare
fix: include zfs arcstats in export list Signed-off-by: Hudson Gerwing <grownuphudson@gmail.com>
hewdoe
force-pushed
the
zfs-arc-compatibility
branch
from
b390ab4
to
ef70132
Compare
Signed-off-by: Hudson Gerwing <grownuphudson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Description
On Linux-based OS's,
/proc/meminfodoes not report memory consumption by the ZFS ARC disks. It's my understanding that this memory is reclaimable.These changes include what "htop" deems "shrinkable" memory into the
used,cachedandavailablememory totals, which solved an issue on one of my systems which was over-reporting memory consumption.Here are a few resources:
https://www.reddit.com/r/zfs/comments/ha0p7f/understanding_arcstat_and_free/
openzfs/zfs#10255
Please note: Throughout the function I edited, there's many references to the outputs behaving like the "free" CLI tool.
This change will make the output behave as "htop" does instead, so if this is undesired please feel free to reject or further decouple this implementation
Please let me know if this is relevant or not and I can add a test and make changes to the
readTheDocsDocumentation too. Just not necessary at the moment for me if this will only ever be used on my fork