[Linux] More tolerant battery detection #2220
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sujaldev
force-pushed
the
master
branch
5 times, most recently
from
5b5472e
to
3d2aa88
Compare
|
If this wasn't being merged due to the merge conflicts, I have resolved those. Also I've rewritten everything such that my proposed method of detecting the battery device path (which is to look at the contents of the directory rather than it's name) only comes into play if the current way of doing things wasn't able to detect a battery. |
|
@giampaolo don't know if you noticed the changes, bump. |
|
I'm deleting the changes to |
Signed-off-by: Sujal Singh <email.sujalsingh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
psutil.sensors_battery()relies on an assumption which is not true of all systems. #2219Description
Implements a more tolerant method for detecting battery.