Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use system-level values for Windows virtual memory #2077

Merged
merged 2 commits into from
Oct 20, 2022
Merged

Use system-level values for Windows virtual memory #2077

merged 2 commits into from
Oct 20, 2022

Commits on Oct 20, 2022

  1. Use system-level values for Windows virtual memory 

    Submitting this as a draft PR as I believe it will address giampaolo#2074.  I do not have either a C or Python development environment to test these changes, so they are provided in the hopes someone else can test and confirm they fix the issue.

There's probably some room to simplify the code with temporary variables to reduce redundancy.

For background, I have implemented precisely this logic in my own (Java-based) project [here](https://github.com/oshi/oshi/blob/3bb9eafbe2062edad4108b7b12501b1f9be27361/oshi-core/src/main/java/oshi/hardware/platform/windows/WindowsVirtualMemory.java#L110-L118) and [here](https://github.com/oshi/oshi/blob/3bb9eafbe2062edad4108b7b12501b1f9be27361/oshi-core/src/main/java/oshi/hardware/platform/windows/WindowsGlobalMemory.java#L253-L263) following a detailed investigation in oshi/oshi#1182

Signed-off-by: Daniel Widdis <widdis@gmail.com>
    @dbwiddis
    dbwiddis committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    195b01d View commit details
    Browse the repository at this point in the history

  2. Formatting, credits, change log 

    Signed-off-by: Daniel Widdis <widdis@gmail.com>
    @dbwiddis
    dbwiddis committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    066c4c1 View commit details
    Browse the repository at this point in the history