Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESM modules #3924

Merged
merged 11 commits into from May 24, 2024
Merged

ESM modules #3924

merged 11 commits into from May 24, 2024

Conversation

chrmod
Copy link
Member

@chrmod chrmod commented Apr 23, 2024

No description provided.

@chrmod chrmod mentioned this pull request Apr 23, 2024
Closed
@chrmod chrmod marked this pull request as ready for review May 10, 2024 10:31
@chrmod chrmod requested a review from remusao as a code owner May 10, 2024 10:31
@chrmod chrmod added the PR: Internal 🏠 Changes only affect internals label May 10, 2024
smalluban
smalluban reviewed May 10, 2024
View reviewed changes
Copy link

@smalluban smalluban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not spot any obvious mistakes in reconfiguration.

remusao
remusao approved these changes May 24, 2024
View reviewed changes
packages/adblocker-playwright-example/output.png Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To remove?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes!

@chrmod chrmod merged commit 3e0ff50 into master May 24, 2024
3 checks passed
@chrmod chrmod deleted the modules branch May 24, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smalluban smalluban smalluban left review comments

@remusao remusao remusao approved these changes

@philipp-classen philipp-classen philipp-classen approved these changes

@seia-soto seia-soto Awaiting requested review from seia-soto

Assignees
No one assigned
Labels
PR: Internal 🏠 Changes only affect internals
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chrmod @remusao @philipp-classen @smalluban