Experimental throttling mode to avoid putting much load on the CPU #3913
+79
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipp-classen
force-pushed
the
experimental_throttling_mode
branch
from
c09d44e
to
acc5246
Compare
if there are bursts of DOM modification events, even though there are no changes. refs ghostery/ghostery-extension#757 refs ghostery/ghostery-extension#1392
philipp-classen
force-pushed
the
experimental_throttling_mode
branch
from
acc5246
to
e194b41
Compare
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimental throttling mode to avoid putting much load on the CPU if there are bursts of DOM modification events, even though there are no changes.
It keeps a set of elements for which most mutations will be skipped.
Context:
refs ghostery/ghostery-extension#757
refs ghostery/ghostery-extension#1392
The best way to reproduce the high CPU load is to use the standalone extension and uBlock Origin together, as described here:
ghostery/ghostery-extension#757 (comment)
Test sites are reddit.com and heise.com. In both cases, the CPU load on Firefox reduces. But note that having dev tools open kills performance. With the console.warn, it can be observed later if a website triggered throttling mode temporarily.