Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phpunit 9 Compatibility #10

Merged
merged 2 commits into from Mar 5, 2020
Merged

Phpunit 9 Compatibility #10

merged 2 commits into from Mar 5, 2020

Conversation

artjomsimon
Copy link
Contributor

  • PHPUnit requires PHP 7.3 => dropped test in .travis.ci, added PHP 7.3 system requirement to composer.json
  • The reference links to Sebastian Bergmann's original TAP printer are broken. I removed them, please feel free to add if you find a working reference link.
  • ResultPrinter is now an interface, see Make PHPUnit\TextUI\ResultPrinter an interface sebastianbergmann/phpunit#4024
    The original Class we extend still exists, however it is marked @internal, so by definition we should now instead implement the Interface and reimplement a majority of the functionality in DefaultResultPrinter, which is also marked as @internal. I decided to not do that in this PR and instead continue extending the DefaultResultPrinter, even though it's marked as @internal.

Please have a look and see if anything can be improved, or if this can be merged.

@gh640 gh640 merged commit 1b69e6a into gh640:master Mar 5, 2020
@gh640
Copy link
Owner

gh640 commented Mar 5, 2020

@artjomsimon thanks for the PR. It looks fine and I've merged it. I released the version 5.0.0 and please try using it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants