Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ResultPrinter
is now an interface, see Make PHPUnit\TextUI\ResultPrinter an interface sebastianbergmann/phpunit#4024The original Class we extend still exists, however it is marked
@internal
, so by definition we should now instead implement the Interface and reimplement a majority of the functionality inDefaultResultPrinter
, which is also marked as@internal
. I decided to not do that in this PR and instead continue extending theDefaultResultPrinter
, even though it's marked as@internal
.Please have a look and see if anything can be improved, or if this can be merged.