Split Blendability and Filterability into Two Different TextureFormatFeatureFlags #3012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
requested changes
Sep 19, 2022
|
Just needs a formatting pass and we're g2g |
auto-merge was automatically disabled
September 20, 2022 08:24
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…FeatureFlags
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Connections
Split Blendability and Filterability into Two Different TextureFormatFeatureFlags #2943
Description
By splitting up Blendability and Filterablity in the texture format feature flags, it is now possible to elude the limitation enforced by WebGPU to have a filterable texture format when blending is set on the color state of the render pipeline by using
Features::TEXTURE_ADAPTER_SPECIFIC_FORMAT_FEATURES.Testing
Tested on
backend = Metal
iOS: 15.6 (both real device and simulator)
device: iPad Pro 2021 12.9"
using the feature flag and the RG32Float format according to the issue described here.