Implement copyExternalImageToTexture

[ybiletskyi]

Connections
A few requests in matrix chat.

Description
This method allow to improve performance of web page, because creating an ImageBitmap causes the image data to be decoded into a GPU-friendly format, and it does so off the main thread. link

Testing
I created an example locally to test the new method.
Let me know if I should push it.

[jimblandy]

Yes, let's include the example, if it's not too large.

[maxammann]

Is it possible to test this using wasm? I'm not sure how to run the examples for Web.

[ybiletskyi]

Is it possible to test this using wasm? I'm not sure how to run the examples for Web.

Yes. You should to run cargo run-wasm --example hello-copy-source

[maxammann]

I kind of failed at testing this. Firefox Nightly does not yet support this. The dev branch of google chrome currently fails to execute any WebGPU demo for me.

I think this feature should also be supported with WebGL. The following command fails for me:

$ cargo run-wasm --example hello-copy-source --features webgl
   Compiling wgpu v0.12.0 (/home/max/projects/wgpu/wgpu)
error[E0599]: no method named `copy_external_image_to_texture` found for struct `Queue` in the current scope
   --> wgpu/examples/hello-copy-source/main.rs:189:19
    |
189 |             queue.copy_external_image_to_texture(&image, texture.as_image_copy(), texture_size);
    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ method not found in `Queue`

For more information about this error, try `rustc --explain E0599`.

[ybiletskyi]

I kind of failed at testing this. Firefox Nightly does not yet support this. The dev branch of google chrome currently fails to execute any WebGPU demo for me.

I think this feature should also be supported with WebGL. The following command fails for me:

$ cargo run-wasm --example hello-copy-source --features webgl
   Compiling wgpu v0.12.0 (/home/max/projects/wgpu/wgpu)
error[E0599]: no method named `copy_external_image_to_texture` found for struct `Queue` in the current scope
   --> wgpu/examples/hello-copy-source/main.rs:189:19
    |
189 |             queue.copy_external_image_to_texture(&image, texture.as_image_copy(), texture_size);
    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ method not found in `Queue`

For more information about this error, try `rustc --explain E0599`.

I tested this changes on the Chrome Canary version. I probably add WebGL support, but I prefer to do it in separate pull request to minimize changes for review.

[anlumo]

#1888

[maxammann]

Whats the status of this? :)

[ybiletskyi]

@maxammann I have resolved conflicts and changes according PR comments. So probably need to await reviewers approve.

[cwfitzgerald]

I still have maintainability concerns about this getting it's own example, but we can tackle that later, I want to get this into the release

[cwfitzgerald]

I have multiple concerns about the example - I don't want to merge the example right now - but I do want to get the core functionality in for this release. I have pushed a change to remove the example from this PR - but I want to continue iterating on the example in another PR!