Add symlink LICENSE files into crates. #2604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Symlink the top-level LICENSE into each published crates.
|
I don't think it is appropriate for me to send this PR since I am not a party to this issue, so I will close this. If this correction looks good, please reopen. |
|
We should only put it in the sub-crates where it's required (and which are published). As such, I don't think we want to modify deno_webgpu and wgpu-info with these. |
Since deno_webgpu and wgpu-info are not dependency of wgpu.
|
I don't think the symlink thing ended up working considering the dffs |
Is it better to put actual copies to those subdirectory? Currently, I'm just naively trying to follow the case of prost. |
cwfitzgerald
approved these changes
May 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symlink the top-level LICENSE into each published crate.
This will resolve #2561