Improve Presentation Api #2803
Merged
Improve Presentation Api #2803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
reviewed
Jun 23, 2022
Co-authored-by: bjorn3 <17426603+bjorn3@users.noreply.github.com>
cwfitzgerald
force-pushed
the
presentation-abi
branch
from
ec54fae
to
24c2921
Compare
|
The changes to framework.rs in Fix issues with ALLOW_TEARING seem to be testing changes that were accidentally committed. |
|
Good catch, thank you! |
cwfitzgerald
force-pushed
the
presentation-abi
branch
from
24c2921
to
c0ecfc5
Compare
daxpedda
reviewed
Jun 29, 2022
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Closes #2711
Closes #2712
Description
This does a couple things:
As a related fix - properly exposes more formats on all vulkan and metal.
In a weird surprise we weren't updated to rust 2021, so I updated it so I could use format strings in an unreachable!.
Commits can be reviewed independently.
Good to review, just don't merge - I need to test on DX12/VK first.
Testing
Manually.