Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fj-app can crash because wgpu doesn't fall back PresentMode to Fifo anymore #1034

Closed
ykomatsu opened this issue Sep 2, 2022 · 2 comments · Fixed by #1035
Closed

fj-app can crash because wgpu doesn't fall back PresentMode to Fifo anymore #1034

ykomatsu opened this issue Sep 2, 2022 · 2 comments · Fixed by #1035

Comments

@ykomatsu
Copy link

ykomatsu commented Sep 2, 2022

wgpu doesn't fall back PresentMode to Fifo after gfx-rs/wgpu/pull/2803 .
This can causes fj-app crash.

On my MacBook Pro (macOS Monterey 12.5.1):

$ RUST_BACKTRACE=1 fj-app -m .
thread 'main' panicked at 'Error in Surface::configure: requested present mode Mailbox is not in the list of supported present modes: [Fifo, Immediate]', /Users/ykoma/.cargo/registry/src/github.com-1ecc6299db9ec823/wgpu-0.13.1/src/backend/direct.rs:281:9
   2: wgpu::backend::direct::Context::handle_error_fatal
   3: <wgpu::backend::direct::Context as wgpu::Context>::surface_configure
   4: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
   5: std::thread::local::LocalKey<T>::with
   6: futures_executor::local_pool::block_on
   7: fj_window::run::run
   8: fj_app::main
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
@ykomatsu ykomatsu changed the title fj-app can crash because wgpu doesn't fall back PresentMode to Fifo anymore fj-app can crash because wgpu doesn't fall back PresentMode to Fifo anymore Sep 2, 2022
@hannobraun
Copy link
Owner

@ykomatsu I've addressed this in #1035. Please let me know, if it works for you now!

@ykomatsu
Copy link
Author

ykomatsu commented Sep 2, 2022

It works!
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants