sr: Deduplicate match ranges like spirv header
#242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msiglreith
approved these changes
Apr 6, 2023
Solve some clippy lints by getting rid of these aliases of overlapping `Op`s. Unfortunately, just like in `spirv`, this biases towards the `NV` rather than `KHR` stabilized raytracing ops. Note that in `spirv` the `Op`s are aliases in code rather than omitted altogether: don't think we can do that for the range match here though unless deducing whether the shader was compiled with the NV or KHR variant, even though the KHR variant is already stabilized for quite some time.
MarijnS95
force-pushed
the
sr-remove-overlapping-match-ranges
branch
from
d29152c
to
f19da5f
Compare
|
@msiglreith are you okay with this change, or should we see if we can prefer the |
|
@MarijnS95 |
|
@msiglreith definitely, it might just be a hassle to implement as all parts of the generator redo these kinds of evaluations on the parsed SPIR-V grammar :( |
|
@msiglreith done now! |
MarijnS95
force-pushed
the
sr-remove-overlapping-match-ranges
branch
from
13892e1
to
f0c0d46
Compare
MarijnS95
force-pushed
the
sr-remove-overlapping-match-ranges
branch
from
f0c0d46
to
05d13a1
Compare
msiglreith
approved these changes
Apr 6, 2023
Yup rather than only listing the few vendors with ops currently I just copied the whole thing from ash-rs/ash#676. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve some clippy lints by getting rid of these aliases of overlapping
Ops. Unfortunately, just like inspirv, this biases towards theNVrather thanKHRstabilized raytracing ops.Note that in
spirvtheOps are aliases in code rather than omitted altogether: don't think we can do that for the range match here though unless deducing whether the shader was compiled with the NV or KHR variant, even though the KHR variant is already stabilized for quite some time.