Allow isort configuration through pyproject.toml #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes the -incorrectly- closed issue #71.
jnns
added a commit
to jnns/flake8-isort
that referenced
this pull request
Feb 29, 2020
isort will look for a configuration in pyproject.toml when the TOML library is available. flake8-isort has its own mechanism to look up an appropriate configuration file and will pass its path on to isort. Right now, flake8-isort doesn't consider pyproject.toml files as configuration file candidates and will raise an error if there's no other configuration file than the pyproject.toml. Luckily, there's the parameter `--no-isort-config` to make flake8-isort not stall when it cannot find a config file. In this case, isort will not be instructed to look for a specific configuration file by flake8-isort but instead look for it itself (beginning from either the currently linted file path or the current working directory). This is great because it means that we can rely on isort to figure out which config to use and linting behavior between both libraries will be exactly the same. The search for a configuration file can be removed from flake8-isort and we get Pyproject.toml support for free. The `--no-isort-config` option can be removed as well because from now on it will always be the burden of isort to figure out which config to use. Related to gforcada#71 Closes gforcada#78
|
I'm not closing this PR just yet but the PR by @jnns looks better. |
|
EDIT: isort 4.3.21 uses |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the -incorrectly- closed issue #71.