Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pyproject.toml. #75

Merged
merged 1 commit into from Dec 4, 2019

Conversation

sanjioh
Copy link
Contributor

@sanjioh sanjioh commented Dec 3, 2019

Fixes #71

@sanjioh sanjioh mentioned this pull request Dec 3, 2019
@gforcada gforcada merged commit 9d6171a into gforcada:master Dec 4, 2019
@gforcada
Copy link
Owner

gforcada commented Dec 4, 2019

@sanjioh thanks for your contribution, it is finally released as flake8-isort 2.8.0 🎉

@uyar
Copy link

uyar commented Jan 7, 2020

@gforcada @sanjioh This doesn't seem to be included in flake8-isort 2.8.0. There is no mention of pyproject.toml in the code. The commit only changes the run_test and setup modules, and not the flake8_isort module. Am I missing something?

@gforcada
Copy link
Owner

gforcada commented Jan 7, 2020

@uyar I thought so myself when I first tried this pull request locally, but (un)fortunately isort, as soon as there is toml available, it uses the pyproject.toml configuration if it is available.

It is good in a way, because without us here in flake8-isort doing anything it already works, but it makes all the configuration searching a bit pointless as isort, despite whatever you give as configuration, still looks for it on its own.

Or at least that's how I understood it, which can be totally wrong 😅

@uyar
Copy link

uyar commented Jan 7, 2020

@gforcada But it didn't work in my environment although toml was available. It failed due to configuration being missing and without calling isort. As least I think that's what happened. I'll check it out tomorrow and get back to you.

@uyar
Copy link

uyar commented Jan 7, 2020

I think the comment by @mikewl on the closed issue #71 is correct.

EDIT: I was writing on my phone, so I couldn't include the author who posted the comment. Fixed that now.

@gforcada
Copy link
Owner

gforcada commented Jan 8, 2020

@uyar thanks for pointing that out, that comment somehow slipped through the cracks and I missed it 😓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for pyproject.toml
3 participants