Support for pyproject.toml #71
Comments
|
Strong +1 on this! |
|
For a few years I've asked for PyCQA/isort#574 which would make this little flake8 plugin's life so much easier, seems it is not getting any followup though 😕 |
|
Understood 🤔 didn’t noticed that. In the meantime, would you be ok in just making |
|
@sanjioh I don't see what we would gain with adding dependencies on We need to update https://github.com/gforcada/flake8-isort/blob/master/flake8_isort.py#L94 |
|
@gforcada It looks like isort picks up any config in
[tool.isort]
line_length = 10
from configparser import ConfigParser
$ flake8 test.py --no-isort-config
test.py:1:1: F401 'configparser.ConfigParser' imported but unused
$ pip install toml
$ flake8 test.py --no-isort-config
test.py:1:1: I001 isort found an import in the wrong position
test.py:1:1: F401 'configparser.ConfigParser' imported but unusedAm I missing something? 🤔 |
|
@gforcada Hi! Any thoughts on this? Thanks! |
|
Oh, I see, despite that we pass where the configuration is, Then yes, 👍 on adding the dependency. Now I'm curious if we actually have to do all the mambo jumbo to get the configuration, if anyway |
|
This probably needs to be reopened. The original: # Check for '[isort]' section in other configuration files.
for config_file in ('tox.ini', 'setup.cfg', '.flake8'):
config_file_path = os.path.join(path, config_file)
config = SafeConfigParser()
config.read(config_file_path)
if 'isort' in config.sections():
return config_file_pathMy modified one that finds the file: # Check for '[isort]' section in other configuration files.
for config_file in ('tox.ini', 'setup.cfg', '.flake8', 'pyproject.toml'):
config_file_path = os.path.join(path, config_file)
config = SafeConfigParser()
config.read(config_file_path)
if 'isort' in config.sections():
return config_file_path
if 'tool.isort' in config.sections():
return config_file_pathIf I am understanding it right then all that is needed this side is the path to send to isort? There is no other logic done to the configuration? If so I will happily make a PR for this. Still don't know what to do with the tests as they do pass with the previous behaviour as well. |
|
I totally missed this last comment, thanks @mikewl for it! A PR is always welcome, thanks in advance! 👍 |
|
I will try getting to this over the weekend. I need to spend some time figuring out why the tests were passing in the first place so that the tests fail appropriately on the current version too. |
|
Thank you so much for this awesome plugin. |
|
@rommguy you need isort 4.3.5 at least, there has been a pull request merged regarding that, but no new release so far. |
isort will look for a configuration in pyproject.toml when the TOML library is available. flake8-isort has its own mechanism to look up an appropriate configuration file and will pass its path on to isort. Right now, flake8-isort doesn't consider pyproject.toml files as configuration file candidates and will raise an error if there's no other configuration file than the pyproject.toml. Luckily, there's the parameter `--no-isort-config` to make flake8-isort not stall when it cannot find a config file. In this case, isort will not be instructed to look for a specific configuration file by flake8-isort but instead look for it itself (beginning from either the currently linted file path or the current working directory). This is great because it means that we can rely on isort to figure out which config to use and linting behavior between both libraries will be exactly the same. The search for a configuration file can be removed from flake8-isort and we get Pyproject.toml support for free. The `--no-isort-config` option can be removed as well because from now on it will always be the burden of isort to figure out which config to use. Related to gforcada#71 Closes gforcada#78
isort will look for a configuration in pyproject.toml when the TOML library is available. flake8-isort has its own mechanism to look up an appropriate configuration file and will pass its path on to isort. Right now, flake8-isort doesn't consider pyproject.toml files as configuration file candidates and will raise an error if there's no other configuration file than the pyproject.toml. Luckily, there's the parameter `--no-isort-config` to make flake8-isort not stall when it cannot find a config file. In this case, isort will not be instructed to look for a specific configuration file by flake8-isort but instead look for it itself (beginning from either the currently linted file path or the current working directory). This is great because it means that we can rely on isort to figure out which config to use and linting behavior between both libraries will be exactly the same. The search for a configuration file can be removed from flake8-isort and we get Pyproject.toml support for free. The `--no-isort-config` option can be removed as well because from now on it will always be the burden of isort to figure out which config to use. Related to gforcada#71 Closes gforcada#78
isort added support for using a
pyproject.tomlfile for it's configuration in version 4.3.5. It would be great if this module could be compatible.The text was updated successfully, but these errors were encountered: