Update to greenlet 2.0 #1922
Merged
Update to greenlet 2.0 #1922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1909 We'll need to release a final greenlet 2.0 and remove the rc qualifiers here before releasing gevent, because pre-release qualifiers are contagious.
Its failing in a weird way that doesn't happen locally. There is a remaining issue, which lies somewhere in greenlet, seen in test__monkey_hub_in_thread and test__threading_monkey_in_thread: Fatal Python error: Python memory allocator called without holding the GIL Python runtime state: finalizing (tstate=0xd5f3e0) Thread 0x00007f511f66b700 (most recent call first): <no Python frame> Obviously this mixes with threads. greenlet uses Py_AddPendingCall to move some work to other threads, but apparently something is still happening at the wrong time.
Request this for the two IDNA cases, which somehow give different errors using the same resolver on GHA.
|
FYI, Python 3.11 has been released. These tests are still against 3.11.0-rc.2 |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1909
Before releasing this, we'll need a greenlet 2.0 final, and to take the 'rcX' qualifiers out of our dependency declarations (since those are sticky).