Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(gevent): pin greenlet for legacy gevent versions #4437

Merged
merged 4 commits into from Nov 3, 2022
Merged

ci(gevent): pin greenlet for legacy gevent versions #4437

merged 4 commits into from Nov 3, 2022

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Nov 1, 2022 •
edited by Yun-Kim

Description

Earlier versions of gevent (v1.1, v1.2, v1.3, v1.4, v20.9) only specify a minimum greenlet version. greenlet v2.0 updated its ABI to support py3.11 and is only compatible with gevent>=22.10.2..

This change updates gevent and opentracer tests to install greenlet<2 if gevent<=20.9 is used.

Checklist

Reviewer Checklist

  • Title is accurate.
  • Description motivates each change.
  • No unnecessary changes were introduced in this PR.
  • Avoid breaking API changes unless absolutely necessary.
  • Tests provided or description of manual testing performed is included in the code or PR.
  • Release note has been added for fixes and features, or else changelog/no-changelog label added.
  • All relevant GitHub issues are correctly linked.
  • Backports are identified and tagged with Mergifyio.

@mabdinur mabdinur added the changelog/no-changelog A changelog entry is not required for this PR. label Nov 1, 2022
brettlangdon
brettlangdon reviewed Nov 1, 2022
View reviewed changes
Copy link
Member

@brettlangdon brettlangdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are any changes needed to riotfile.py?

@mabdinur
Copy link
Contributor Author

mabdinur commented Nov 1, 2022

are any changes needed to riotfile.py?

Nope, we only use the latest gevent version in riot.

mabdinur
mabdinur commented Nov 1, 2022
View reviewed changes
tox.ini Show resolved Hide resolved
@mabdinur mabdinur marked this pull request as ready for review November 1, 2022 15:22
@mabdinur mabdinur requested a review from a team as a code owner November 1, 2022 15:22
Kyle-Verhoog
Kyle-Verhoog previously approved these changes Nov 1, 2022
View reviewed changes
brettlangdon
brettlangdon previously approved these changes Nov 1, 2022
View reviewed changes
@Kyle-Verhoog
Copy link
Member

@mabdinur opentracing is still failing on gevent: https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/23030/workflows/a85977a7-c9b0-42d5-88c6-bd4eaee54b4a/jobs/1566740

@mabdinur
Copy link
Contributor Author

mabdinur commented Nov 1, 2022

@Mergifyio backport 1.6 1.5 1.4 0.61

@mergify
Copy link
Contributor

mergify bot commented Nov 1, 2022 •
edited

backport 1.6 1.5 1.4 0.61

✅ Backports have been created

@Kyle-Verhoog Kyle-Verhoog merged commit b85fca2 into 1.x Nov 3, 2022
@Kyle-Verhoog Kyle-Verhoog deleted the munir/fix-ci-pin-greenlet branch November 3, 2022 14:02
@mergify mergify bot mentioned this pull request Nov 3, 2022
Merged
mergify bot pushed a commit that referenced this pull request Nov 3, 2022
@mabdinur @mergify
ci(gevent): pin greenlet for legacy gevent versions (#4437)
1d8be4b 
Earlier versions of gevent (v1.1, v1.2, v1.3, v1.4, v20.9) only specify a minimum greenlet version. greenlet v2.0 updated its ABI to support py3.11 and is only compatible with gevent>=22.10.2..

This change updates gevent and opentracer tests to install greenlet<2 if gevent<=20.9 is used.

Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
(cherry picked from commit b85fca2)
@github-actions github-actions bot added this to the v1.7.0 milestone Nov 3, 2022
@mergify mergify bot mentioned this pull request Nov 3, 2022
Merged
mergify bot pushed a commit that referenced this pull request Nov 3, 2022
@mabdinur @mergify
ci(gevent): pin greenlet for legacy gevent versions (#4437)
5457f20 
Earlier versions of gevent (v1.1, v1.2, v1.3, v1.4, v20.9) only specify a minimum greenlet version. greenlet v2.0 updated its ABI to support py3.11 and is only compatible with gevent>=22.10.2..

This change updates gevent and opentracer tests to install greenlet<2 if gevent<=20.9 is used.

Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
(cherry picked from commit b85fca2)

# Conflicts:
#	tox.ini
@mergify mergify bot mentioned this pull request Nov 3, 2022
Closed
mergify bot pushed a commit that referenced this pull request Nov 3, 2022
@mabdinur @mergify
ci(gevent): pin greenlet for legacy gevent versions (#4437)
4b1c0e7 
Earlier versions of gevent (v1.1, v1.2, v1.3, v1.4, v20.9) only specify a minimum greenlet version. greenlet v2.0 updated its ABI to support py3.11 and is only compatible with gevent>=22.10.2..

This change updates gevent and opentracer tests to install greenlet<2 if gevent<=20.9 is used.

Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
(cherry picked from commit b85fca2)

# Conflicts:
#	tox.ini
@mergify mergify bot mentioned this pull request Nov 3, 2022
Merged
mergify bot pushed a commit that referenced this pull request Nov 3, 2022
@mabdinur @mergify
ci(gevent): pin greenlet for legacy gevent versions (#4437)
f6e7d26 
Earlier versions of gevent (v1.1, v1.2, v1.3, v1.4, v20.9) only specify a minimum greenlet version. greenlet v2.0 updated its ABI to support py3.11 and is only compatible with gevent>=22.10.2..

This change updates gevent and opentracer tests to install greenlet<2 if gevent<=20.9 is used.

Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
(cherry picked from commit b85fca2)

# Conflicts:
#	tox.ini
@Kyle-Verhoog Kyle-Verhoog mentioned this pull request Nov 3, 2022
Closed
10 tasks
@jd
Copy link
Contributor

jd commented Nov 3, 2022

@mabdinur
I looked into the profiling failure and there's something very odd. Basically, the atexit of uwsgi is interrupted abruptly at a random point which prevents the profiler to flush out the profile. I'm not sure what happens under the hood, if a greenlet is never resumed or something.

Kyle-Verhoog pushed a commit that referenced this pull request Nov 3, 2022
@mergify @mabdinur
ci(gevent): pin greenlet for legacy gevent versions (#4437) (#4453)
a649188 
Earlier versions of gevent (v1.1, v1.2, v1.3, v1.4, v20.9) only specify a minimum greenlet version. greenlet v2.0 updated its ABI to support py3.11 and is only compatible with gevent>=22.10.2..

This change updates gevent and opentracer tests to install greenlet<2 if gevent<=20.9 is used.

Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
(cherry picked from commit b85fca2)

Co-authored-by: Munir Abdinur <munir.abdinur@datadoghq.com>
Kyle-Verhoog pushed a commit that referenced this pull request Nov 8, 2022
@mergify @mabdinur
ci(gevent): pin greenlet for legacy gevent versions (backport #4437) (#…
bfe56c4 
…4454)

* ci(gevent): pin greenlet for legacy gevent versions (#4437)

Earlier versions of gevent (v1.1, v1.2, v1.3, v1.4, v20.9) only specify a minimum greenlet version. greenlet v2.0 updated its ABI to support py3.11 and is only compatible with gevent>=22.10.2..

This change updates gevent and opentracer tests to install greenlet<2 if gevent<=20.9 is used.


Co-authored-by: Munir Abdinur <munir.abdinur@datadoghq.com>
Kyle-Verhoog pushed a commit that referenced this pull request Nov 8, 2022
@mergify @mabdinur
ci(gevent): pin greenlet for legacy gevent versions (backport #4437) (#…
ec0f291 
…4456)

* ci(gevent): pin greenlet for legacy gevent versions (#4437)

Earlier versions of gevent (v1.1, v1.2, v1.3, v1.4, v20.9) only specify a minimum greenlet version. greenlet v2.0 updated its ABI to support py3.11 and is only compatible with gevent>=22.10.2..

This change updates gevent and opentracer tests to install greenlet<2 if gevent<=20.9 is used.

Co-authored-by: Munir Abdinur <munir.abdinur@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kyle-Verhoog Kyle-Verhoog Kyle-Verhoog approved these changes

@Yun-Kim Yun-Kim Yun-Kim approved these changes

@brettlangdon brettlangdon Awaiting requested review from brettlangdon

Assignees
No one assigned
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mabdinur @Kyle-Verhoog @jd @brettlangdon @Yun-Kim