feat: Move vcs backend to asyncio #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcramer
force-pushed
the
feat/asyncio-vcs
branch
from
2ddb953
to
f7ec893
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 12, 2020
329: feat: Move vcs backend to asyncio r=dcramer a=dcramer The core goal here is to resolve some IO latency/blocking in vcs-server when `git fetch` takes a long period of time. This upgrades us to Python 3.8.1 as well to make use of AsyncMock. Note, pytest is locked at <5.4 right now, and is currently broken as of the 5.4.0 release. Co-authored-by: David Cramer <dcramer@gmail.com>
|
pytest bug that I discovered while doing this is here pytest-dev/pytest#6909 |
Build failed |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 13, 2020
329: feat: Move vcs backend to asyncio r=dcramer a=dcramer The core goal here is to resolve some IO latency/blocking in vcs-server when `git fetch` takes a long period of time. This upgrades us to Python 3.8.1 as well to make use of AsyncMock. Note, pytest is locked at <5.4 right now, and is currently broken as of the 5.4.0 release. Co-authored-by: David Cramer <dcramer@gmail.com>
Build failed |
The core goal here is to resolve some IO latency/blocking in vcs-server when `git fetch` takes a long period of time. This upgrades us to Python 3.8.1 as well to make use of AsyncMock. Note, pytest is locked at <5.4 right now, and is currently broken as of the 5.4.0 release.
dcramer
force-pushed
the
feat/asyncio-vcs
branch
from
f7ec893
to
6d28fd6
Compare
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The core goal here is to resolve some IO latency/blocking in vcs-server when
git fetchtakes a long period of time.This upgrades us to Python 3.8.1 as well to make use of AsyncMock.
Note, pytest is locked at <5.4 right now, and is currently broken as of the 5.4.0 release.