Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for embedded debug IDs in minified files #765

Merged
merged 4 commits into from
Feb 21, 2023

Conversation

mitsuhiko
Copy link
Member

This adds support for parsing debugId references in the source file. It also provides utilities for parsing the comments separately so that code does not need to be written another time in other places.

Followup to #762

Refs getsentry/sentry-cli#1469

@mitsuhiko mitsuhiko requested review from a team and loewenheim February 21, 2023 14:49
@github-actions
Copy link

github-actions bot commented Feb 21, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against da65287

Comment on lines +22 to +25
#[derive(Deserialize)]
struct DebugIdInSourceMap {
debug_id: Option<DebugId>,
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, haven't seen this trick before.

@loewenheim
Copy link
Contributor

There is also this struct in symbolicator that handles the distinction of a sourcemap url either being an actual url or a BASE64 encoding of the contents. Do you think this should also be moved to symbolic?

https://github.com/getsentry/symbolicator/blob/ed2bbfc294ef69cce0772c92ae5dfc9dec01d4a8/crates/symbolicator-service/src/services/sourcemap_lookup.rs#L29

@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Merging #765 (767110c) into master (68147ad) will increase coverage by 0.14%.
The diff coverage is 93.61%.

❗ Current head 767110c differs from pull request most recent head da65287. Consider uploading reports for the commit da65287 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #765      +/-   ##
==========================================
+ Coverage   74.53%   74.68%   +0.14%     
==========================================
  Files          70       71       +1     
  Lines       15317    15392      +75     
==========================================
+ Hits        11417    11495      +78     
+ Misses       3900     3897       -3     

@mitsuhiko mitsuhiko merged commit 00b21ab into master Feb 21, 2023
@mitsuhiko mitsuhiko deleted the feature/embedded-debug-id branch February 21, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants