New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix): Use venv created by pre-commit for validate config #3166
Conversation
Codecov ReportBase: 93.04% // Head: 92.82% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3166 +/- ##
==========================================
- Coverage 93.04% 92.82% -0.22%
==========================================
Files 678 688 +10
Lines 31010 31078 +68
==========================================
- Hits 28852 28847 -5
- Misses 2158 2231 +73
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
validate-configs-syntax
pre-commit hook should be using the venv created by pre-commit by default when specifyinglanguage: python
. Callingpython3 ./snuba/validate_configs.py
does not import the current directory by default. This can be achieved by running the library module as a script. Thanks @asottile-sentry for the reference.