Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cache): plot and highlight transaction samples #70521

Merged
merged 2 commits into from May 9, 2024
Merged

feat(cache): plot and highlight transaction samples #70521

merged 2 commits into from May 9, 2024
+107 −14

Conversation

DominikB2014
Copy link
Contributor

  1. plots the transaction samples on the cache sidebar
  2. Allows samples to be highlighted (similar to other starfish modules)
image

@DominikB2014 DominikB2014 requested a review from a team as a code owner May 8, 2024 17:58
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 8, 2024
@codecov Codecov
Copy link

codecov bot commented May 8, 2024

Bundle Report

Changes will decrease total bundle size by 12.1kB ⬇️

Bundle name Size Change
app-webpack-bundle-array-push 26.7MB 12.1kB ⬇️

@DominikB2014 DominikB2014 merged commit 36980c8 into master May 9, 2024
41 of 42 checks passed
@DominikB2014 DominikB2014 deleted the DominikB2014/plot-transaction-samples branch May 9, 2024 15:25
@sentry-io Sentry.io
Copy link

sentry-io bot commented May 15, 2024 •
edited

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Cannot read properties of undefined (reading 'data') /performance/cache/ View Issue
  • ‼️ TypeError: Cannot read properties of undefined (reading 'data') /performance/cache/ View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gggritso gggritso gggritso approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DominikB2014 @gggritso