ref(rules): Add changes to rule edit confirmation notification #66847
+169
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
schew2381
reviewed
Mar 13, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #66847 +/- ##
==========================================
+ Coverage 84.29% 84.31% +0.01%
==========================================
Files 5306 5309 +3
Lines 237157 237411 +254
Branches 41016 41064 +48
==========================================
+ Hits 199915 200165 +250
- Misses 37023 37027 +4
Partials 219 219
|
ceorourke
force-pushed
the
ceorourke/edit-notification-details
branch
from
87872e2
to
4ae40b8
Compare
ceorourke
commented
Mar 13, 2024
schew2381
reviewed
Mar 13, 2024
src/sentry/integrations/slack/message_builder/notifications/rule_save_edit.py
Outdated
Show resolved
Hide resolved
schew2381
approved these changes
Mar 13, 2024
| old_value = prior_state.get(key) | ||
| new_value = present_state.get(key) | ||
| return f"Changed {word} from *{old_value}* to *{new_value}*" | ||
| return None |
There was a problem hiding this comment.
small nit: can skip returning None
There was a problem hiding this comment.
mypy wouldn't let me 😭
There was a problem hiding this comment.
apparently by design: python/mypy#7511 (comment)
There's a flag --no-warn-no-return to disable this but looks like we don't have it on
JonasBa
pushed a commit
that referenced
this pull request
Mar 17, 2024
Follow up to #66285 to add details about what changed happened when a rule was edited to the notification. <img width="748" alt="Screenshot 2024-03-12 at 4 40 24 PM" src="https://github.com/getsentry/sentry/assets/29959063/e0d7c5ca-35e5-4a66-bc67-e53c8d27dcce"> Note that I've made a couple follow up tickets to address poor rendering of issue type enums and frequency: getsentry/team-core-product-foundations#158 and getsentry/team-core-product-foundations#157 --------- Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #66285 to add details about what changed happened when a rule was edited to the notification.
Note that I've made a couple follow up tickets to address poor rendering of issue type enums and frequency: https://github.com/getsentry/team-core-product-foundations/issues/158 and https://github.com/getsentry/team-core-product-foundations/issues/157