ref(sdk): Bump to JS SDK 6.12 Beta to try out experiment #28173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've added an experimental option to the js sdk to capture all changes to LCP instead of just the final value. This puts us on the beta cut with the change and turns the 'reportAllChanges' option on. As for how / why we're doing this, essentially the assumption that the web vitals library makes is that the vital will be reported eventually when the user does something. Since we can't have transactions open forever, this will constantly update intermediate values onto the transaction instead of waiting for the final value before. Since we now have a way to discern LCP element (etc) this should pose low risk in terms of reducing data accuracy, but we're going to try it out on Sentry first.
k-fish
force-pushed
the
ref/sdk-test-out-js-beta-lcp-changes
branch
from
2f54d0a
to
a3b94e8
Compare
dashed
approved these changes
Aug 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We've (@AbhiPrasad and me 😄 ) added an experimental option to the js sdk to capture all changes to LCP instead of just the final value. This puts us on the beta cut with the change and turns the 'reportAllChanges' option on.
Why though?
As for why we're doing this, essentially the assumption that the web vitals library makes is that the vital will be reported eventually when the user does something, which is uses to finalize the value and report it. Since we can't have transactions open forever, this will constantly update intermediate values onto the transaction instead of waiting for the final value. Since we now have a way to discern LCP element (etc) this should pose low risk in terms of reducing data accuracy, but we're going to try it out on Sentry first.
tldr; The LCP measurements for Sentry javascript project might change, but if you are already controlling for LCP element, if anything it should just make our numbers more accurate.
related: getsentry/sentry-javascript#3879