build(jest): Use jest-circus as test runner
#17681
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with ZEIT Now (learn more). |
This is the next-gen test runner for jest. It provides an event handler so that we can add apm to our test suite. See https://github.com/facebook/jest/tree/master/packages/jest-circus for more information.
billyvg
force-pushed
the
build/jest/use-jest-circus-test-runner
branch
from
24acb72
to
fe14dda
Compare
billyvg
commented
Mar 16, 2020
| @@ -260,24 +259,4 @@ describe('api', function() { | |||
| ); | |||
| }); | |||
| }); | |||
|
|
|||
| describe('Sentry reporting', function() { | |||
| beforeEach(function() { | |||
There was a problem hiding this comment.
Empty beforeEach that does nothing.
| @@ -58,11 +63,6 @@ describe('ProjectPluginDetails', function() { | |||
| ); | |||
| }); | |||
|
|
|||
| afterAll(function() { | |||
| // eslint-disable-next-line no-console | |||
| console.info.restore(); | |||
There was a problem hiding this comment.
restore is not a valid jest mock fn fn
|
Whoa this is cool af |
billyvg
commented
Mar 16, 2020
.travis.yml
Outdated
| @@ -34,7 +34,7 @@ env: | |||
| - DJANGO_VERSION=">=1.11,<1.12" | |||
| # node's version is pinned by .nvmrc and is autodetected by `nvm install`. | |||
| - NODE_DIR="${HOME}/.nvm/versions/node/v$(< .nvmrc)" | |||
| - NODE_OPTIONS=--max-old-space-size=4096 | |||
| - NODE_OPTIONS=--max-old-space-size=6144 | |||
There was a problem hiding this comment.
circus seems to require for memory :(
|
Going to gather more data before trying to get this merged. There are a variety of performance issues. See: |
|
Closing due to staleness and conflicts. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the next-gen test runner for jest. It provides an event handler so that we can add apm to our test suite.
See https://github.com/facebook/jest/tree/master/packages/jest-circus for more information.